Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate rocm-pytorch and rocm-tensorflow runtime images #626

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Jul 19, 2024

Related to: https://issues.redhat.com/browse/RHOAIENG-9680
Depends on: #620

Description

Include PyTorch AMD and Tensorflow AMD images in the pre-included runtime image lists.
We need to provide runtime images with AMD support so that they can be used in the Pipeline creation via Elyra component or directly.

NOTE: This PR has dependency of this one: #620 as for the runtime builds the base image is amd-ubi9-python-3.9

Follow up items that will break up on different tracking tasks:

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from dibryant and paulovmr July 19, 2024 07:44
Copy link
Contributor

openshift-ci bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from atheo89. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member Author

atheo89 commented Jul 19, 2024

Build Notebooks (pr) / Generate job matrix (pull_request) Failing because this PR should be merged first. #620
(Check the note on the PR description)

Copy link
Contributor

openshift-ci bot commented Jul 19, 2024

@atheo89: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/amd-runtimes-ubi9-e2e-tests 767e285 link true /test amd-runtimes-ubi9-e2e-tests
ci/prow/runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror 767e285 link true /test runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror
ci/prow/images 767e285 link true /test images
ci/prow/rocm-notebooks-e2e-tests 767e285 link true /test rocm-notebooks-e2e-tests
ci/prow/notebook-rocm-ubi9-python-3-9-pr-image-mirror 767e285 link true /test notebook-rocm-ubi9-python-3-9-pr-image-mirror

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant