feat(ci): add helpful error when check-generated-code gha workflow fails #627
Conversation
.github/workflows/code-quality.yaml
Outdated
| @@ -23,6 +23,7 @@ jobs: | |||
| if [[ -z "$clean" ]]; then | |||
| echo "Empty git status --porcelain: $clean" | |||
| else | |||
| echo "::error::Please run the command from the previous step (Rerun all code generators...) and commit the result." | |||
There was a problem hiding this comment.
Please, instead of telling to run command from previous step, maybe we should explicitly say what to run.
There was a problem hiding this comment.
Ok, then, let me change this.
jiridanek
force-pushed
the
jd_helpful_error
branch
from
669dde5
to
5873f07
Compare
.github/workflows/code-quality.yaml
Outdated
| @@ -15,14 +15,15 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
|
|
|||
| - name: Rerun all code generators we have | |||
| run: python3 ci/cached-builds/gen_gha_matrix_jobs.py | |||
| run: bash ci/generate_code.bash | |||
There was a problem hiding this comment.
I don't like the .bash suffix :P , I can see we have it in one file already ./ci/cached-builds/gha_lvm_overlay.bash... still, do we want to extend this policy?
There was a problem hiding this comment.
it's only tested with bash; when I get the mac, I will also test it on zsh
There was a problem hiding this comment.
What does the file suffix have to do with the which interpreter is used?
There was a problem hiding this comment.
changed back to .sh, for consistency
ci/generate_code.bash
Outdated
|
|
||
| if ! python3 ci/cached-builds/gen_gha_matrix_jobs.py; then | ||
| # this returns nonzero when running outside of github; detect and print explanation | ||
| if [[ ${GITHUB_ACTIONS:-} == true ]]; then exit 1 |
There was a problem hiding this comment.
It's a pitty that the script fails when non-run in github... I consider this solution as a workaround that will be fixed and won't be needed in the near future; we may miss other reasons why the script failed when run locally with this approach.
There was a problem hiding this comment.
Yeah, it's not a good job on my part.
There was a problem hiding this comment.
I was not too had to fix, did it rn
|
/lgtm |
|
Thank you, I like this much more now! /lgtm |
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…to finish the shell script renaming
|
New changes are detected. LGTM label has been removed. |
|
/override ci/prow/runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror one rocm run out of ephemeral storage, and tests hit the chicken-and-egg problem from openshift/release#54567 |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/amd-runtimes-ubi9-e2e-tests, ci/prow/images, ci/prow/runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
How Has This Been Tested?
Merge criteria: