Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Update DSP Server - Data Connections #1214

Closed
andrewballantyne opened this issue May 9, 2023 · 11 comments · Fixed by #1719
Closed

[Feature Request]: Update DSP Server - Data Connections #1214

andrewballantyne opened this issue May 9, 2023 · 11 comments · Fixed by #1719
Assignees
Labels
feature/ds-pipelines Data Science Pipelines feature (aka DSP) field-priority Flag to track improvements that are for stability -- effort to put in front of new functionality kind/enhancement New functionality request (existing augments or new additions) migrated priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.

Comments

@andrewballantyne
Copy link
Member

andrewballantyne commented May 9, 2023

Solution

  • Mocks are listed in Yan's comment
  • Replace the Data Connection functionality with a direct "Object Connection" functionality
    • All fields are required & a name is no longer needed
    • Fields: Access key, Secret key, endpoint, bucket
  • Allow for a prefill from a Data Connection for reuse of data they have already setup
    • This hopefully can be a fancy dropdown in PF, but explore what components might be useful in v4 of PF
    • Make sure you have a "hide" secret functionality so we don't expose the Secret key value
  • DO NOT implement the typeahead feature for first pass

Feature description

Today we allow the use of Data Connections in setting up of the Data Science Pipelines Server.

This actually is not a proper representation of what is happening. This may lead the user to think we are "associating" the Data Connection to their Pipeline Server. So they could assume changes to the Data Connection would be reflected here. This is not the case technically.

Suggested changes:

  • We change the UX so it does not say "use existing" data connection & we just provide 4 of the fields (key, secret, endpoint, bucket) directly, all required
  • We will create a secret by the static name mlpipeline-minio-artifact, and provide the same keys as we do today
    • We'll want to push the db-password secret (when applicable) into this secret too so that the server can use it all at once

This should separate the relationship between the Data Connection & the DSPA.

Side note: We may want to prefill the information from an existing Data Connection -- TBD, bringing it up at the UX Meeting this Thursday.

Describe alternatives you've considered

No response

Anything else?

No response

@andrewballantyne andrewballantyne added kind/enhancement New functionality request (existing augments or new additions) untriaged Indicates the newly create issue has not been triaged yet feature/ds-pipelines Data Science Pipelines feature (aka DSP) labels May 9, 2023
@andrewballantyne andrewballantyne added this to the Future Relase milestone May 9, 2023
@Gkrumbach07 Gkrumbach07 added priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. and removed untriaged Indicates the newly create issue has not been triaged yet labels May 10, 2023
@andrewballantyne
Copy link
Member Author

We do not have a concrete idea of how this will look. @kywalker-rh we can make them add it directly as a first pass -- but we should look at some way to say "prefill from existing" if someone wants to reuse the values they have already added.

@andrewballantyne andrewballantyne removed this from the Current Release milestone Jul 6, 2023
@andrewballantyne andrewballantyne added the field-priority Flag to track improvements that are for stability -- effort to put in front of new functionality label Jul 14, 2023
@andrewballantyne
Copy link
Member Author

@kywalker-rh I just flagged this as field-priority.

@andrewballantyne
Copy link
Member Author

@pnaik1 pnaik1 self-assigned this Aug 3, 2023
@lucferbux lucferbux added this to the Upcoming Release milestone Aug 9, 2023
@yannnz
Copy link

yannnz commented Aug 10, 2023

This is the latest design: Update DSP Server mockup. Need @kaedward to help on reviewing the content.

@kaedward
Copy link

@andrewballantyne I'm not sure I understand exactly what is happening during the "enable pipelines" process - is there any other information we can provide about what exactly "enable pipelines" means? This would be helpful for the empty state, as well. I'm imagining something along the lines of "enable pipelines for use on your system" or "for your account"... but I'm sure that's not accurate. :-)

@pnaik1
Copy link
Contributor

pnaik1 commented Aug 22, 2023

@andrewballantyne , does bucket field needs to a mandatory field in the new implementation?

@andrewballantyne
Copy link
Member Author

@andrewballantyne , does bucket field needs to a mandatory field in the new implementation?

That's what the mocks say @pnaik1. Do note that it's not the same fields as we have in the Data Connection modal because this is very much targeted for DSPA creation.

@yannnz can you remove the typeahead functionality from your mocks? We discussed that in the UX Meeting doc file and it appears still in your last comment.

@andrewballantyne
Copy link
Member Author

@pnaik1 I've updated the description to help detail out the solution more. Let me know if you're still unsure of anything.

@pnaik1
Copy link
Contributor

pnaik1 commented Aug 22, 2023

@andrewballantyne thanks , this clarifies most of my doubts

@yannnz
Copy link

yannnz commented Aug 23, 2023

@andrewballantyne @pnaik1 I've removed the typeahead function in my mockup, you can refresh the same link to find it. There are also content updates based on Katie's suggestion.

@adnankhan666
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/ds-pipelines Data Science Pipelines feature (aka DSP) field-priority Flag to track improvements that are for stability -- effort to put in front of new functionality kind/enhancement New functionality request (existing augments or new additions) migrated priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
Status: Done
Archived in project
Status: Dashboard
Development

Successfully merging a pull request may close this issue.

7 participants