Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Wrong TLS Option in dashboard route #1639

Closed
1 task done
lucferbux opened this issue Aug 7, 2023 · 1 comment · Fixed by #1640
Closed
1 task done

[Bug]: Wrong TLS Option in dashboard route #1639

lucferbux opened this issue Aug 7, 2023 · 1 comment · Fixed by #1640
Assignees
@lucferbux
Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/bug Something isn't working priority/normal An issue with the product; fix when possible rhods-1.33

Comments

@lucferbux
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Deploy type

OpenDataHub core version (eg. v1.6.0)

Version

1.7.0

Current Behavior

The current values for route.openshift.io/v1/spec/tls/termination are edge, passthrough and reencrypt, if you give another value it will fail silently, we have Reencrypt as default value.

Expected Behavior

To have the right value in our deployment.

Steps To Reproduce

No response

Workaround (if any)

No response

What browsers are you seeing the problem on?

No response

Anything else

No response
@lucferbux lucferbux added kind/bug Something isn't working untriaged Indicates the newly create issue has not been triaged yet priority/normal An issue with the product; fix when possible labels Aug 7, 2023
@lucferbux lucferbux mentioned this issue Aug 7, 2023
Merged
7 tasks
@shalberd
Copy link
Contributor

shalberd commented Aug 7, 2023

yes, good catch https://docs.openshift.com/container-platform/4.10/networking/routes/secured-routes.html#nw-ingress-creating-a-reencrypt-route-with-a-custom-certificate_secured-routes

@lucferbux lucferbux modified the milestones: Current Release, Upcoming Release Aug 9, 2023
@manaswinidas manaswinidas added infrastructure Anything non feature/* related that improves general working of the Dashboard and removed untriaged Indicates the newly create issue has not been triaged yet labels Aug 9, 2023
@andrewballantyne andrewballantyne removed this from the Current Release milestone Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucferbux lucferbux

Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/bug Something isn't working priority/normal An issue with the product; fix when possible rhods-1.33
Projects
ODH Dashboard Planning
Archived in project
ODH Feature Tracking
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tls option in odh-dashboard route lucferbux/odh-dashboard
4 participants
@andrewballantyne @lucferbux @shalberd @manaswinidas