-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tls option in odh-dashboard route #1640
Fix tls option in odh-dashboard route #1640
Conversation
nice catch, cool, lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/hold Let's wait until next release for this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/unhold
Release was made, this can go into the next
LGTM.
@@ -10,7 +10,7 @@ spec: | |||
targetPort: 8443 | |||
tls: | |||
insecureEdgeTerminationPolicy: Redirect | |||
termination: Reencrypt | |||
termination: reencrypt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, DaoDaoNoCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lucferbux How does this release note text sound? Wrong TLS value in dashboard routePreviously, when a route was created for the {productname-short} dashboard on OpenShift, the |
Description
Closes #1639
How Has This Been Tested?
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main