Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tls option in odh-dashboard route #1640

Merged

Conversation

lucferbux
Copy link
Contributor

Description

Closes #1639

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@shalberd
Copy link
Contributor

shalberd commented Aug 7, 2023

nice catch, cool, lgtm

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucferbux
Copy link
Contributor Author

/hold

Let's wait until next release for this one.

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Aug 9, 2023
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

Release was made, this can go into the next

LGTM.

@@ -10,7 +10,7 @@ spec:
targetPort: 8443
tls:
insecureEdgeTerminationPolicy: Redirect
termination: Reencrypt
termination: reencrypt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wild that the OpenShift folks chose lowercase for this but not for all properties -- I would imagine all of these are just magic strings.

But it is in the API Explorer as such
image

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Aug 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, DaoDaoNoCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c555422 into opendatahub-io:main Aug 17, 2023
6 checks passed
@jbyrne-redhat
Copy link

@lucferbux How does this release note text sound?

Wrong TLS value in dashboard route

Previously, when a route was created for the {productname-short} dashboard on OpenShift, the tls.termination field had an invalid default value of Reencrypt. This issue is now resolved. The new value is reencrypt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong TLS Option in dashboard route
6 participants