Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Default designator disappears when selecting a notebook that isn't the default #1690

Closed
1 task done
catrobson opened this issue Aug 21, 2023 · 11 comments · Fixed by #1708
Closed
1 task done
Assignees
Labels
feature/notebook-controller KubeFlow NoteBook Controller (KFNBC) Feature good first issue Good for newcomers kind/bug Something isn't working priority/normal An issue with the product; fix when possible rhods-1.33

Comments

@catrobson
Copy link

catrobson commented Aug 21, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Deploy type

Downstream version (eg. RHODS 1.29)

Version

RHODS Sandbox version

Current Behavior

When selecting a notebook that isn't the default notebook, the default designator on the screen disappears. When selecting back to the default, it reappears.

Expected Behavior

Default designator is always visible, regardless of radio selection of any notebook on the screen.

UX decided on removing the (default) text (#1690 (comment))

Steps To Reproduce

  1. In RHODS Sandbox version (sorry, cannot find version number), Launch Jupyter application.
  2. On Start Notebook Server page, it starts with Minimal Python 2023.1 (default) selected.
  3. Selecting the following notebooks results in (default) suffix moving to that selection: CUDA 2023.1, TensorFlow
    2023.1, Standard Data Science 2023.1, PyTorch 2023.1
  4. Selecting the following notebooks results in (default) suffix disappearing completely: oneAPI AI Analytics Toolkit (also why is this listed twice?), OpenVINO™ Toolkit v2022.1

Selected on initial default:
image

Selected on new item now with "default" suffix:
image

Disappears completely:
image

Workaround (if any)

Not blocking any user task, just confusing.

What browsers are you seeing the problem on?

Chrome

Anything else

No response

@catrobson catrobson added kind/bug Something isn't working priority/normal An issue with the product; fix when possible untriaged Indicates the newly create issue has not been triaged yet labels Aug 21, 2023
@manaswinidas manaswinidas removed the untriaged Indicates the newly create issue has not been triaged yet label Aug 23, 2023
@manaswinidas
Copy link
Contributor

cc @xianli123 This is likely a UX issue. Default means default version and that's confusing.

@manaswinidas manaswinidas added feature/notebook-controller KubeFlow NoteBook Controller (KFNBC) Feature needs-ux labels Aug 23, 2023
@manaswinidas
Copy link
Contributor

This does not happen in ds-projects

@xianli123
Copy link

@manaswinidas @catrobson Thanks for involving me. I often use the RHODS dashboard and I can't see the "Launch Jypter" page in the sandbox version. The below screenshot shows what I can see in the Sandbox version. I guess I may not have the permission to see that.
Screenshot 2023-08-24 at 11 57 35

Go back to this issue. I see the same interaction as what you shared @catrobson in the RHODS dashboard. I agree with you that the default designator should always appear regardless of whether the option is selected or not.
As for the "default" designator, I think we can put it next to the subtitle rather than the main title as shown in the screenshot below. Because @manaswinidas mentioned that Default means default version, it'd better be next to the version info. What do you think?

Screenshot 2023-08-24 at 14 17 07

@catrobson
Copy link
Author

+1 that moving it next to the version number and not having it appear/disappear would be ideal if this is meant to designate that the user is currently selecting the default version.

@andrewballantyne
Copy link
Member

Worth noting @xianli123 that Minimal Python is the name of the image. 2023.1 is the version (the versions expand will show this value and another -- n / n+1 concept). Python v3.9 is the packaged version of the lang used in the image.

We have (Recommended) on DS Projects -- I think this is just the curse of the old UI. We can go with something small for now, but we will need to be really reworking this portion of the Dashboard to fixing the issue. I'll have to dig up the plans for that and prioritize it, it's getting a bit crazy having two UIs for this.

@xianli123
Copy link

Thanks for your explanation @andrewballantyne

2023.1 is the version (the versions expand will show this value and another -- n / n+1 concept).

Oh, sorry for misunderstanding the meaning of the version.

We can go with something small for now, but we will need to be really reworking this portion of the Dashboard to fixing the issue. I'll have to dig up the plans for that and prioritize it, it's getting a bit crazy having two UIs for this.

That makes sense. If you have any plans for this, please let me know and I can contribute to this part.

@xianli123
Copy link

@catrobson As andrewballantyne mentioned that 2023.1 is the version (the versions expand will show this value and another -- n / n+1 concept) and I found that the default version is highlighted by the Recommended, so I think the smallest effective change is to remove all “Default" labels. And we can separate an issue to discuss how to improve the visibility of the "Recommended" version. Does it make sense?

Screenshot 2023-08-25 at 12 37 14

@andrewballantyne
Copy link
Member

Seems like an easy change to me... 👍

@andrewballantyne andrewballantyne added good first issue Good for newcomers and removed needs-ux labels Aug 25, 2023
@dpanshug dpanshug self-assigned this Aug 26, 2023
@xianli123
Copy link

Do we need to separate an issue to discuss how to improve the visibility of the "Recommended" version?

@andrewballantyne
Copy link
Member

Do we need to separate an issue to discuss how to improve the visibility of the "Recommended" version?

Yes please, log a new issue to state what you'd like changed. Worth noting, eventually (some distant future probably) we will be converting this design into the same design that is in the Workbench form for DS Projects. So perhaps not hugely needed imo, but I'll leave that up to you @xianli123

@xianli123
Copy link

@andrewballantyne Ok. I will dig into the new issue and try to come up with solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/notebook-controller KubeFlow NoteBook Controller (KFNBC) Feature good first issue Good for newcomers kind/bug Something isn't working priority/normal An issue with the product; fix when possible rhods-1.33
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants