Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BYON]: In some places in the dashboard instead of notebook images its mentioned as byon-image #352

Closed
1 task done
mwaykole opened this issue Jul 26, 2022 · 3 comments · Fixed by #426
Closed
1 task done

[BYON]: In some places in the dashboard instead of notebook images its mentioned as byon-image #352

mwaykole opened this issue Jul 26, 2022 · 3 comments · Fixed by #426
Assignees
@andrewballantyne
Labels
feature/byon Bring Your Own Notebook Feature kind/bug Something isn't working priority/normal An issue with the product; fix when possible

Comments

@mwaykole
Copy link

mwaykole commented Jul 26, 2022 •
edited

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

In some places in the dashboard instead of notebook images its mentioned as byon-image

Expected Behavior

The name should be consistent in all the places either Byon-image or Notebook-image
@mwaykole mwaykole added kind/bug Something isn't working untriaged Indicates the newly create issue has not been triaged yet labels Jul 26, 2022
@mwaykole mwaykole changed the title [Bug]: [KFNBC] In some places in the dashboard instead of notebook images its mentioned as byon-image [KFNBC] In some places in the dashboard instead of notebook images its mentioned as byon-image Jul 26, 2022
@mwaykole
Copy link
Author

![Screenshot from 2022-07-26 11-47-08](https://user-images.githubusercontent.com/44530572/180937666-de4d3b80-3694-4df4-b3b8-613d9e9fa4
Screenshot from 2022-07-26 11-46- Screenshot from 2022-07-26 11-46-48 58
7f.png)

@mwaykole
Copy link
Author

Screenshot from 2022-07-26 11-46-48
Screenshot from 2022-07-26 11-47-08

@DaoDaoNoCode
Copy link
Member

This looks like not a KFNBC bug. It's a naming issue for BYON feature.

@andrewballantyne andrewballantyne changed the title [KFNBC] In some places in the dashboard instead of notebook images its mentioned as byon-image [BYON]: In some places in the dashboard instead of notebook images its mentioned as byon-image Jul 26, 2022
@andrewballantyne andrewballantyne added priority/normal An issue with the product; fix when possible and removed untriaged Indicates the newly create issue has not been triaged yet labels Jul 26, 2022
@andrewballantyne andrewballantyne added the feature/byon Bring Your Own Notebook Feature label Aug 9, 2022
@andrewballantyne andrewballantyne self-assigned this Aug 19, 2022
@andrewballantyne andrewballantyne mentioned this issue Aug 19, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewballantyne andrewballantyne

Labels
feature/byon Bring Your Own Notebook Feature kind/bug Something isn't working priority/normal An issue with the product; fix when possible
Projects
ODH Dashboard Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup BYON references in the UI andrewballantyne/odh-dashboard
3 participants
@andrewballantyne @DaoDaoNoCode @mwaykole