Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup BYON references in the UI #426

Conversation

andrewballantyne
Copy link
Member

@andrewballantyne andrewballantyne commented Aug 19, 2022

Resolves #352

Description

Just cleaning up some UI references to BYON. Should be just Notebook

How Has This Been Tested?

Searched for all references and clicked around in the UI to check contextual usages.

Screenshots

Screen Shot 2022-08-19 at 3 53 36 PM
Screen Shot 2022-08-19 at 3 53 41 PM
Screen Shot 2022-08-19 at 3 53 58 PM

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit df79e6b into opendatahub-io:main Aug 22, 2022
LaVLaS pushed a commit to LaVLaS/odh-dashboard that referenced this pull request Aug 26, 2022
LaVLaS pushed a commit to red-hat-data-services/odh-dashboard that referenced this pull request Aug 31, 2022
strangiato pushed a commit to strangiato/odh-dashboard that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BYON]: In some places in the dashboard instead of notebook images its mentioned as byon-image
3 participants