Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Tolerations have no validation #515

Closed
1 task done
andrewballantyne opened this issue Sep 8, 2022 · 1 comment · Fixed by #536
Closed
1 task done

[Bug]: Tolerations have no validation #515

andrewballantyne opened this issue Sep 8, 2022 · 1 comment · Fixed by #536
Assignees
Labels
feature/notebook-controller KubeFlow NoteBook Controller (KFNBC) Feature kind/bug Something isn't working priority/normal An issue with the product; fix when possible
Milestone

Comments

@andrewballantyne
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Tolerations field in the Cluster Settings page for an Admin do not protect against any misuse of the field.

There are restrictions to the field under the hood, like having a valid K8s name (https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names) that we can do to help the admin out.

Tracking the valid relationship of the toleration is out of scope.

Expected Behavior

Present the user with additional error help when they have an invalid name.

"name part must consist of alphanumeric characters, '-', '' or '.', and must start and end with an alphanumeric character (e.g. 'MyName', or 'my.name', or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9.]*)?[A-Za-z0-9]')"

Steps To Reproduce

  1. Be an admin
  2. Go to Cluster Settings page
  3. Type an invalid name with spaces or non-supported special characters

Workaround (if any)

No response

OpenShift Infrastructure Version

No response

Openshift Version

No response

What browsers are you seeing the problem on?

No response

Open Data Hub Version

2.1

Relevant log output

No response

@andrewballantyne andrewballantyne added kind/bug Something isn't working untriaged Indicates the newly create issue has not been triaged yet feature/notebook-controller KubeFlow NoteBook Controller (KFNBC) Feature priority/normal An issue with the product; fix when possible and removed untriaged Indicates the newly create issue has not been triaged yet labels Sep 8, 2022
@andrewballantyne andrewballantyne added this to the Release 2.2.0 milestone Sep 8, 2022
@andrewballantyne
Copy link
Member Author

If part of this work we can do a wider box to at least support the default value would be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/notebook-controller KubeFlow NoteBook Controller (KFNBC) Feature kind/bug Something isn't working priority/normal An issue with the product; fix when possible
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant