Add name check logic to Toleration in ClusterSettings #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewballantyne
requested review from
dlabaj and
DaoDaoNoCode
and removed request for
LaVLaS and
maroroman
dlabaj
suggested changes
Sep 13, 2022
| <HelperTextItem hasIcon variant="error"> | ||
| {notebookTolerationSettings.error} | ||
| </HelperTextItem> | ||
| )} |
There was a problem hiding this comment.
Can you change line 419 to isDisabled={!isSettingsChanged || notebookTolerationSettings.error !== undefined} That should prevent the user from saving bad values.
andrewballantyne
force-pushed
the
toleration-error-check
branch
from
eca5116
to
e0d693e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlabaj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LaVLaS
pushed a commit
to LaVLaS/odh-dashboard
that referenced
this pull request
Sep 19, 2022
…#536) * Add name check logic to Toleration in ClusterSettings * Block saving when tolerations are in error
LaVLaS
pushed a commit
to LaVLaS/odh-dashboard
that referenced
this pull request
Sep 20, 2022
…#536) * Add name check logic to Toleration in ClusterSettings * Block saving when tolerations are in error
strangiato
pushed a commit
to strangiato/odh-dashboard
that referenced
this pull request
Oct 18, 2023
…#536) * Add name check logic to Toleration in ClusterSettings * Block saving when tolerations are in error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #515
Description
Added the regexp k8s tells us and a similar error message so the Toleration Key is checked in real time.
Screen.Recording.2022-09-12.at.6.42.08.AM.mov
How Has This Been Tested?
Tested on the Toleration key in the Cluster Settings page.
Merge criteria: