Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: SVG Images with no widht and height are not displayed #867

Closed
1 task done
lucferbux opened this issue Jan 2, 2023 · 0 comments · Fixed by #869
Closed
1 task done

[Bug]: SVG Images with no widht and height are not displayed #867

lucferbux opened this issue Jan 2, 2023 · 0 comments · Fixed by #869
Assignees
@DaoDaoNoCode
Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/bug Something isn't working priority/blocker Critical issue that needs to be fixed asap; blocks up coming releases visual changes An issue where the User Interface or Experience changes
Milestone
v2.6.0

Comments

@lucferbux
Copy link
Contributor

lucferbux commented Jan 2, 2023 •
edited

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

If you fill an svg image for a ISV card in either the explore section or the resources page, it might not be displayed in some browsers such as Firefox, there are several ISV downstream such as this one who doesn't contain either the width or height so they are not rendered.

This happens in the brand logo too.

Screenshot 2023-01-02 at 15 25 36

Screenshot 2023-01-03 at 16 22 24

Expected Behavior

All the cards should be filled with images.

Screenshot 2023-01-02 at 15 25 55

Steps To Reproduce

  1. Deploy the latest version of the dashboard
  2. Either remove the width and height from jupyter or deploy other ISV like this one
  3. Check that it doesn't render the image both in firefox and safari

What browsers are you seeing the problem on?

  • Firefox
  • Safari
@lucferbux lucferbux added kind/bug Something isn't working priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. labels Jan 2, 2023
@lucferbux lucferbux added this to the Next Release milestone Jan 2, 2023
@lucferbux lucferbux changed the title [Bug]: SVG Images in explore section with no widht and height are not displayed [Bug]: SVG Images with no widht and height are not displayed Jan 3, 2023
@DaoDaoNoCode DaoDaoNoCode mentioned this issue Jan 3, 2023
Merged
3 tasks
@lucferbux lucferbux added priority/blocker Critical issue that needs to be fixed asap; blocks up coming releases and removed priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. labels Jan 3, 2023
@andrewballantyne andrewballantyne added the infrastructure Anything non feature/* related that improves general working of the Dashboard label Jan 9, 2023
@andrewballantyne andrewballantyne added the visual changes An issue where the User Interface or Experience changes label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaoDaoNoCode DaoDaoNoCode

Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/bug Something isn't working priority/blocker Critical issue that needs to be fixed asap; blocks up coming releases visual changes An issue where the User Interface or Experience changes
Projects
ODH Dashboard Planning
Archived in project
Milestone
v2.6.0
Development

Successfully merging a pull request may close this issue.

render SVG in the card header when height and width are not set DaoDaoNoCode/odh-dashboard
3 participants
@andrewballantyne @lucferbux @DaoDaoNoCode