render SVG in the card header when height and width are not set #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucferbux
approved these changes
Jan 3, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lucferbux
pushed a commit
to red-hat-data-services/odh-dashboard
that referenced
this pull request
Jan 27, 2023
…datahub-io#869) * render SVG in the card header when height and width are not set * update brand
strangiato
pushed a commit
to strangiato/odh-dashboard
that referenced
this pull request
Oct 18, 2023
…datahub-io#869) * render SVG in the card header when height and width are not set * update brand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #867
How Has This Been Tested?
Add OpenVino CR or any other CRs which doesn't contain
widthandheightin their SVG definition, use firefox to open the explore page and check whether the icon is shown.Merge criteria: