Fix a11y errors in DSP screens #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
frontend/src/pages/notebookController/screens/server/ImageTagPopover.tsx
Outdated
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: DaoDaoNoCode, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Double reviewed by the devs, adding Approved label without investigating. |
cfchase
added a commit
to cfchase/odh-dashboard
that referenced
this pull request
Apr 28, 2023
* f/pipelines: Fix a11y errors in DSP screens (opendatahub-io#1125) Fix a11y violations in Settings -> Notebook Images (opendatahub-io#1143)
andrewballantyne
pushed a commit
to andrewballantyne/odh-dashboard
that referenced
this pull request
Apr 28, 2023
* fix a11y errors in DSP screens * format * PR feedback from Juntao * remove unused imports * add inline styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1104
Description
Fixed a11y violations in DSP screens, see JIRA tickets in #1104. Attached screenshots below. Remaining changes were tested with VO.
How Has This Been Tested?
DSP list before:
DSP list after:
Create workbench before:
Create workbench after:
Request review criteria: