Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode secret values #1156

Merged
merged 1 commit into from Apr 19, 2023

Conversation

Gkrumbach07
Copy link
Member

closes: #1110

Description

added a prop too pass a function into the env field that applies the function before submitting

How Has This Been Tested?

  1. Have a project
  2. Create a Workbench
  3. Env Vars => Secret => Upload Secret
  4. Drag and drop a secret file (you can grab this from OpenShift Console and save it as a file in it's encoded state)

Test Impact

bug fix -> no new tests

Request review criteria:

  • The commits have meaningful messages (squashes happen on merge by the bot).
  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for the quick fix!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 15d6bf4 into opendatahub-io:main Apr 19, 2023
5 checks passed
@Gkrumbach07 Gkrumbach07 deleted the decode-bug branch August 10, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Upload Secret double encodes the values
3 participants