Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made env upload category more specific #1209

Merged

Conversation

Gkrumbach07
Copy link
Member

closes: #1206

Description

When secret upload was added, the category for the env upload was "upload" for both secrets and config maps. B/c the upload for secret was checked first, uploaded envs would always be created as secrets.

How Has This Been Tested?

create a workbench with an uploaded config map and make sure it is created as a config map and not a secret

Test Impact

no impact

Request review criteria:

  • The commits have meaningful messages (squashes happen on merge by the bot).
  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)
    no ux changes

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested and its working fine:
Screenshot 2023-05-10 at 18 33 04

Screenshot 2023-05-10 at 18 32 53

@lucferbux
Copy link
Contributor

/assign @andrewballantyne

Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't upload secrets 🤔

Was this broken by your code? -- Yup. Because we didn't implement the reference to Secret UPLOAD when we did it originally -- https://github.com/opendatahub-io/odh-dashboard/blob/main/frontend/src/pages/projects/screens/spawner/spawnerUtils.ts#L323

@openshift-ci openshift-ci bot removed the lgtm label May 10, 2023
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 296e99e into opendatahub-io:main May 11, 2023
5 checks passed
@Gkrumbach07 Gkrumbach07 deleted the create-configmap-bug branch August 10, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: configmap gets stored as a secret after creation
4 participants