-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OVMS OOTB with GPU support #1262
Add OVMS OOTB with GPU support #1262
Conversation
@vconzola I've attached a screenshot just to validate if this is what you were expecting, maybe we can review the name of the GPU one |
@Xaenalt If we can validate the spec it would be super helpful, I'm still confused about the different images in ovms. |
I think we wanted to go with |
b8d7017
to
89ede09
Compare
89ede09
to
489f8f6
Compare
I didn't realize that both runtimes would have the exact same name. Yuck! But it is what it is. Instead of parenthetical text after the name, can we put "GPU required" in a label, just like "Pre-installed". I think that will draw more attention. |
@lucferbux Actually, seeing how this looks to the end user, maybe "Supports GPUs" makes more sense than "GPU required". What do you think? |
mmmm, the hole point of getting this to the display name is that is displayed in the selection of the runtime (I'm gonna attach new screenshots). We can add a label too, but what should we do in the modal selection? |
012c7ff
to
0ec6626
Compare
I understand what you're saying. This looks good. |
Looks good to me, we validated the correct image tag to use as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
This looks good by all parties -- only holding until I get confirmation from Lucas.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It should be fine by now, based on conversations we had this should be the image, already tested so it's working as intended. |
Description
Closes: #1257
How Has This Been Tested?
Test Impact
Test will be done in the follow up testing section for Custom Serving Runtime
Request review criteria: