pipelines modal use up top date data connections #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrewballantyne this should fix the issue |
andrewballantyne
requested changes
Jun 2, 2023
| const dataConnections = useContextResourceData<DataConnection>(useDataConnections(namespace)); | ||
| const { | ||
| dataConnections: { data: dataConnections }, | ||
| } = React.useContext(ProjectDetailsContext); |
There was a problem hiding this comment.
This breaks being able to add it with an existing connection on the global pages...
andrewballantyne
approved these changes
Jun 2, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1307
Description
using context data connection instead of using hook as it was always stale. also passing data connection into form section so it always has the same data
How Has This Been Tested?
Test Impact
pipelines tests are in an issue already
Request review criteria: