no pipelines error fix #1412
no pipelines error fix #1412
Conversation
| @@ -90,7 +90,7 @@ const fetchDashboardCR = async (fastify: KubeFastifyInstance): Promise<Dashboard | |||
| ) | |||
| .then((res) => { | |||
| const dashboardCR = res?.body as DashboardConfig; | |||
| return [dashboardCR]; | |||
| return [_.merge({}, blankDashboardCR, dashboardCR)]; // merge with blank CR to prevent any missing values | |||
There was a problem hiding this comment.
btw, I needed to edit this same file in another PR, it just bothers me that we are using both async/await and promises at the same time, it's kinda hard to read and it could lead to issues, I would say we either use one or another if you want I can rework my PR and you can piggyback into those changes.
There was a problem hiding this comment.
Sure. What pr are you talking about. I can switch my implementation
There was a problem hiding this comment.
#1407 This is the one, I'm adding changes and including that specific one
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@lucferbux @Gkrumbach07 very nice, thanks a bunch :-) working as intended now using the latest code base from you
no more error message that pipelines operator is not installed. Cool thing also about the new search link and only letting users see it if they can install CSVs |
* no pipelines error fix * removed comments
closes: #1379
Description
backend: blank config is merged for all calls to get dashboard config
frontend: updated no pipelines page to use useAccessReview and redirect to a search for the operator instead of direct link to it
How Has This Been Tested?
Test Impact
none
Request review criteria: