If you delete a Pipeline, the run reference leads to a meaningful message

[pnaik1]

Closes: #1324

Description

#1324
The page displays the correct error message and a link to navigate to pipeline page

How Has This Been Tested?

1. Create a Pipeline
2. Create a Run for that Pipeline
3. Delete the Pipeline
4. View the Run on the Global Runs list page
5. Click on the Pipeline link

Test Impact

no test coverage

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• The commits have meaningful messages (squashes happen on merge by the bot).
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[pnaik1]

cc @kywalker-rh can you take a look?

[andrewballantyne]

@pnaik1 can we not avoid the header "Loading..." & the action items in the top right? ... perhaps we can replace the title with something else? I wonder if the breadcrumbs have value to take you back... maybe we can look into using React Router to send us back to where we came from?

This is a reasonable stop-gap though for showing an error screen like we did before.

I suspect Kyle will know more of what we can do.

[uidoyen]

/lgtm

[kywalker-rh]

It seems weird to have the page still say "Loading...", my assumption from seeing this page is we are no longer loading, we've discovered it doesn't exist.

So in that case we should simply call the page "Pipeline not found". If we can remember the pipeline name from the link we should make it "Pipeline 'pipeline name' not found", and if we can't actually find the name we should remove the 'pipeline name' part (so in that case it would just be the existing text).

Hopefully that is clear.

Also, for the Actions button in the top right, we should simply disable it.

[andrewballantyne]

Perhaps we just simplify this and just show nothing but the 404?

Maybe we could mount the ApplicationPage, but make the body the 404 component you made. It would allow us to have some structure. Let me know if you want to talk about this.

I suggested two solutions as it really depends on how each looks. Maybe take screenshots of both or something.

[pnaik1]

@andrewballantyne we can have a look

[pnaik1]

@andrewballantyne So I made the changes as per your request
withActionButton.webm
so you can observe that while loading, we have action button , So I think its not right to have this button , I have added additional condition in https://github.com/opendatahub-io/odh-dashboard/pull/1497/files#diff-153248b4472ef25aa4c01cf4f312bdddef50f7fe6052090df18ddd810437af90R87-R88
this is the final one Renewedpipeline.webm

this will also solve when we use the wrong template , even here we dont want the action button to be displayed

[kywalker-rh]

I'm pretty sure "Wrong pipeline" is your name of a test pipeline, but just want to double check we're not telling a user they have a wrong pipeline.

Also, I'm not totally following your thread, but if its significantly easier to simply not show the Actions button, instead of disabling it, I'm fine with that too.

[pnaik1]

@kywalker-rh yeah the wrong pipeline is the pipeline name
So lets make it little simplified
I have made the changes and the changes look like this

you have suggested this one to remove the action button and the name change part

[kywalker-rh]

Looks good! Thanks for confirming the name. :)

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, uidoyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pnaik1]

I have rebased the branch

[andrewballantyne]

/lgtm