Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge 'f/byon' to incubation #1629

Merged
merged 23 commits into from
Aug 1, 2023
Merged

merge 'f/byon' to incubation #1629

merged 23 commits into from
Aug 1, 2023

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Aug 1, 2023

Description

Add custom notebook phase 1 work to incubation branch

How Has This Been Tested?

Image locations you could use to test:

  • quay.io/opendatahub/workbench-images:jupyter-minimal-ubi8-python-3.8-pr-89 (valid)
  • docker.io/invalid/invalid (invalid)
  • quay.io/opendatahub/workbench-images:invalid (invalid)

Test instructions:

  1. Go to Settings -> Notebook image settings
  2. Click on Import notebook image, and try to create an image using the locations above
  3. Try to add packages and software to the image, you can add anything you want
  4. Test the keyboard interactions when inputting packages/software, when you edit a row, hit Enter could help you to save the row and move to the next row. If you are current on the last row, it will create a new row. Hit Esc could exit the edit mode and abandon the current change on the row.

Test checklist:

  • Make sure you could import a new image
  • Make sure the sort and search of the table work
  • The invalid images have an error state with the Enable toggle locked and disabled
  • When you input the image location with an invalid format, make sure the modal won't close but show an error alert inside
  • Make sure you can successfully update and delete the image

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

uidoyen and others added 23 commits June 28, 2023 14:23
Elyra Pipelines Lack Proper Task Names
This reverts commit e7f3931.

Revert "added cr"

This reverts commit 61413fb.

Revert "added accelerator profile crd"

This reverts commit 7fce600.
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Add volume to change shared memory limit on notebook
…components, manifest list digest of v4.10 as of July 8 or so
…andard_v410_based_digest

standard ose-oauth-proxy image in digest format as used in all other …
Uploading a malformed pipeline yaml results in a blank page
Update modals and generate meaningful k8s name for images
Gracefully handle image packages and software JSON parse error
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Aug 1, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2023

@DaoDaoNoCode: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 9fef3fb link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Checked the items in the checklist. All looks good.

@openshift-ci openshift-ci bot added the lgtm label Aug 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: manaswinidas
Once this PR has been reviewed and has the lgtm label, please assign andrewballantyne for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DaoDaoNoCode DaoDaoNoCode merged commit 48c91fb into incubation Aug 1, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm needs-rebase PR needs to be rebased
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants