BYON front end code. #171

dlabaj · 2022-04-05T20:37:10Z

This PR adds the following functionality to the UI:

Import BYON Image
Adds BYON Table
Adds Notebook Images setting
Adds ability to delete notebook images
Adds ability to edit notebook images
Allows user to turn on and off the visibility of a notebook image.
Integrates with BYON Rest API.

dlabaj · 2022-04-07T14:37:16Z

CC/ @tumido

.env

frontend/src/utilities/time.ts

frontend/src/utilities/useWatchNotebookImages.tsx

frontend/src/types.ts

frontend/src/services/notebookImageService.ts

LaVLaS

/lgtm

backend/src/routes/api/notebook/notebooksUtils.ts

Updated front end code with import and start of table. Updated with byon changes Updated code with byon ui changes. Integrated import, delete, and get functionality for notebooks. Added start of edit panel. Updated build error fixes. Updates to edit dialog and linting cleanup. Added sort to table. Added filtering. Added failure warning to allow user to click Add check disable enabling failed notebook images Fixed with review comments. Fixed time bug. Removed admin

Updated with REST api notebook image endpoints and new notebook image types. Updated REST API (opendatahub-io#155) * Updated with REST API design changes. Fixed formatting error. * Update backend/src/types.ts Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> Updated type.ts in front end with Succeeded [byon] Implement backend (opendatahub-io#156) * feat(byon): List all notebooks Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Get single notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * fix(byon): Update api spec to include software and id Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Schedule new notebook import Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Delete notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Update notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> Rebased BYON from master (opendatahub-io#162) * Updated way that to detect an admin. (opendatahub-io#137) Fixed linting error. * Update backend port setting and makefile dev commands. (opendatahub-io#133) * Update README.md (opendatahub-io#96) Updated Readme to specify that a build is required prior to running the development server. * Fix for input not allowing blank spaces.: Fix to allow a user to enter an empty string. Fixed with review comment. * Add culler timeout settings feature (opendatahub-io#134) * Added types for notebookimage and status (opendatahub-io#147) Updated with REST api notebook image endpoints and new notebook image types. * Updated REST API (opendatahub-io#155) * Updated with REST API design changes. Fixed formatting error. * Update backend/src/types.ts Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> * Updated type.ts in front end with Succeeded * [byon] Implement backend (opendatahub-io#156) * feat(byon): List all notebooks Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Get single notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * fix(byon): Update api spec to include software and id Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Schedule new notebook import Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Delete notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Update notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> Co-authored-by: Christopher Chase <cchase@redhat.com> Co-authored-by: Chad Roberts <croberts@redhat.com> Co-authored-by: Juntao Wang <37624318+DaoDaoNoCode@users.noreply.github.com> Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> fix(byon): Use notebook-image label for visibility toggle (opendatahub-io#169) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> feat(byon): Feat add creator annotation (opendatahub-io#170) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> feat(byon): Allow to patch name and description on notebook (opendatahub-io#172) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> feat(byon): Allow python dependency visibility field changes (opendatahub-io#173) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> Added code for importing byon image. (opendatahub-io#171) Updated front end code with import and start of table. Updated with byon changes Updated code with byon ui changes. Integrated import, delete, and get functionality for notebooks. Added start of edit panel. Updated build error fixes. Updates to edit dialog and linting cleanup. Added sort to table. Added filtering. Added failure warning to allow user to click Add check disable enabling failed notebook images Fixed with review comments. Fixed time bug. Removed admin

Updated with REST api notebook image endpoints and new notebook image types. Updated REST API (opendatahub-io#155) * Updated with REST API design changes. Fixed formatting error. * Update backend/src/types.ts Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> Updated type.ts in front end with Succeeded [byon] Implement backend (opendatahub-io#156) * feat(byon): List all notebooks Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Get single notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * fix(byon): Update api spec to include software and id Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Schedule new notebook import Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Delete notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Update notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> Rebased BYON from master (opendatahub-io#162) * Updated way that to detect an admin. (opendatahub-io#137) Fixed linting error. * Update backend port setting and makefile dev commands. (opendatahub-io#133) * Update README.md (opendatahub-io#96) Updated Readme to specify that a build is required prior to running the development server. * Fix for input not allowing blank spaces.: Fix to allow a user to enter an empty string. Fixed with review comment. * Add culler timeout settings feature (opendatahub-io#134) * Added types for notebookimage and status (opendatahub-io#147) Updated with REST api notebook image endpoints and new notebook image types. * Updated REST API (opendatahub-io#155) * Updated with REST API design changes. Fixed formatting error. * Update backend/src/types.ts Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> * Updated type.ts in front end with Succeeded * [byon] Implement backend (opendatahub-io#156) * feat(byon): List all notebooks Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Get single notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * fix(byon): Update api spec to include software and id Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Schedule new notebook import Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Delete notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Update notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> Co-authored-by: Christopher Chase <cchase@redhat.com> Co-authored-by: Chad Roberts <croberts@redhat.com> Co-authored-by: Juntao Wang <37624318+DaoDaoNoCode@users.noreply.github.com> Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> fix(byon): Use notebook-image label for visibility toggle (opendatahub-io#169) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> feat(byon): Feat add creator annotation (opendatahub-io#170) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> feat(byon): Allow to patch name and description on notebook (opendatahub-io#172) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> feat(byon): Allow python dependency visibility field changes (opendatahub-io#173) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> Added code for importing byon image. (opendatahub-io#171) Updated front end code with import and start of table. Updated with byon changes Updated code with byon ui changes. Integrated import, delete, and get functionality for notebooks. Added start of edit panel. Updated build error fixes. Updates to edit dialog and linting cleanup. Added sort to table. Added filtering. Added failure warning to allow user to click Add check disable enabling failed notebook images Fixed with review comments. Fixed time bug. Removed admin Update backend port setting and makefile dev commands. (opendatahub-io#133) Use webpack dev server proxy instead of CORS utilities (opendatahub-io#127) Fixed issues with cherry picks.

Updated with REST api notebook image endpoints and new notebook image types. Updated REST API (opendatahub-io#155) * Updated with REST API design changes. Fixed formatting error. * Update backend/src/types.ts Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> Updated type.ts in front end with Succeeded [byon] Implement backend (opendatahub-io#156) * feat(byon): List all notebooks Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Get single notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * fix(byon): Update api spec to include software and id Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Schedule new notebook import Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Delete notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Update notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> Rebased BYON from master (opendatahub-io#162) * Updated way that to detect an admin. (opendatahub-io#137) Fixed linting error. * Update backend port setting and makefile dev commands. (opendatahub-io#133) * Update README.md (opendatahub-io#96) Updated Readme to specify that a build is required prior to running the development server. * Fix for input not allowing blank spaces.: Fix to allow a user to enter an empty string. Fixed with review comment. * Add culler timeout settings feature (opendatahub-io#134) * Added types for notebookimage and status (opendatahub-io#147) Updated with REST api notebook image endpoints and new notebook image types. * Updated REST API (opendatahub-io#155) * Updated with REST API design changes. Fixed formatting error. * Update backend/src/types.ts Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> * Updated type.ts in front end with Succeeded * [byon] Implement backend (opendatahub-io#156) * feat(byon): List all notebooks Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Get single notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * fix(byon): Update api spec to include software and id Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Schedule new notebook import Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Delete notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Update notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> Co-authored-by: Christopher Chase <cchase@redhat.com> Co-authored-by: Chad Roberts <croberts@redhat.com> Co-authored-by: Juntao Wang <37624318+DaoDaoNoCode@users.noreply.github.com> Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> fix(byon): Use notebook-image label for visibility toggle (opendatahub-io#169) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> feat(byon): Feat add creator annotation (opendatahub-io#170) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> feat(byon): Allow to patch name and description on notebook (opendatahub-io#172) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> feat(byon): Allow python dependency visibility field changes (opendatahub-io#173) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> Added code for importing byon image. (opendatahub-io#171) Updated front end code with import and start of table. Updated with byon changes Updated code with byon ui changes. Integrated import, delete, and get functionality for notebooks. Added start of edit panel. Updated build error fixes. Updates to edit dialog and linting cleanup. Added sort to table. Added filtering. Added failure warning to allow user to click Add check disable enabling failed notebook images Fixed with review comments. Fixed time bug. Removed admin Update backend port setting and makefile dev commands. (opendatahub-io#133) Use webpack dev server proxy instead of CORS utilities (opendatahub-io#127) Fixed issues with cherry picks. Fixed additional git cherry pick issues. Added ability to add packages, modify packages, etc. Added software package on import. Added additional table and fix some styling issues. Fixed issue where form was submitted. Updated import in notebooksUtils.ts Updated code to work with image streams instead of pipelines.

[UPSTREAM] Fix to allow a user to enter an empty string. Fixed linting error. Updated to read userTrackingEnabled instead of clusterSettings.userTrackingEnabled. [Upstream] Added BYON, webpack proxy, and CORS heading fix. Updated with REST api notebook image endpoints and new notebook image types. Updated REST API (opendatahub-io#155) * Updated with REST API design changes. Fixed formatting error. * Update backend/src/types.ts Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> Updated type.ts in front end with Succeeded [byon] Implement backend (opendatahub-io#156) * feat(byon): List all notebooks Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Get single notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * fix(byon): Update api spec to include software and id Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Schedule new notebook import Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Delete notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Update notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> Rebased BYON from master (opendatahub-io#162) * Updated way that to detect an admin. (opendatahub-io#137) Fixed linting error. * Update backend port setting and makefile dev commands. (opendatahub-io#133) * Update README.md (opendatahub-io#96) Updated Readme to specify that a build is required prior to running the development server. * Fix for input not allowing blank spaces.: Fix to allow a user to enter an empty string. Fixed with review comment. * Add culler timeout settings feature (opendatahub-io#134) * Added types for notebookimage and status (opendatahub-io#147) Updated with REST api notebook image endpoints and new notebook image types. * Updated REST API (opendatahub-io#155) * Updated with REST API design changes. Fixed formatting error. * Update backend/src/types.ts Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> * Updated type.ts in front end with Succeeded * [byon] Implement backend (opendatahub-io#156) * feat(byon): List all notebooks Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Get single notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * fix(byon): Update api spec to include software and id Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Schedule new notebook import Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Delete notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Update notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> Co-authored-by: Christopher Chase <cchase@redhat.com> Co-authored-by: Chad Roberts <croberts@redhat.com> Co-authored-by: Juntao Wang <37624318+DaoDaoNoCode@users.noreply.github.com> Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> fix(byon): Use notebook-image label for visibility toggle (opendatahub-io#169) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> feat(byon): Feat add creator annotation (opendatahub-io#170) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> feat(byon): Allow to patch name and description on notebook (opendatahub-io#172) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> feat(byon): Allow python dependency visibility field changes (opendatahub-io#173) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> Added code for importing byon image. (opendatahub-io#171) Updated front end code with import and start of table. Updated with byon changes Updated code with byon ui changes. Integrated import, delete, and get functionality for notebooks. Added start of edit panel. Updated build error fixes. Updates to edit dialog and linting cleanup. Added sort to table. Added filtering. Added failure warning to allow user to click Add check disable enabling failed notebook images Fixed with review comments. Fixed time bug. Removed admin Update backend port setting and makefile dev commands. (opendatahub-io#133) Use webpack dev server proxy instead of CORS utilities (opendatahub-io#127) Fixed issues with cherry picks. Fixed additional git cherry pick issues. Added ability to add packages, modify packages, etc. Added software package on import. Added additional table and fix some styling issues. Fixed issue where form was submitted. Updated import in notebooksUtils.ts Updated code to work with image streams instead of pipelines. Fixed linting errors. Fixed empty software package bug. Fixed bugs found during testing. Notebook image table update. Fixed error where not showing the empty state. Fixed table issue. Add another update of the notbook image table.

[UPSTREAM] Fix to allow a user to enter an empty string. Fixed linting error. Updated to read userTrackingEnabled instead of clusterSettings.userTrackingEnabled. [Upstream] Added BYON, webpack proxy, and CORS heading fix. Updated with REST api notebook image endpoints and new notebook image types. Updated REST API (opendatahub-io#155) * Updated with REST API design changes. Fixed formatting error. * Update backend/src/types.ts Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> Updated type.ts in front end with Succeeded [byon] Implement backend (opendatahub-io#156) * feat(byon): List all notebooks Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Get single notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * fix(byon): Update api spec to include software and id Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Schedule new notebook import Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Delete notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Update notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> Rebased BYON from master (opendatahub-io#162) * Updated way that to detect an admin. (opendatahub-io#137) Fixed linting error. * Update backend port setting and makefile dev commands. (opendatahub-io#133) * Update README.md (opendatahub-io#96) Updated Readme to specify that a build is required prior to running the development server. * Fix for input not allowing blank spaces.: Fix to allow a user to enter an empty string. Fixed with review comment. * Add culler timeout settings feature (opendatahub-io#134) * Added types for notebookimage and status (opendatahub-io#147) Updated with REST api notebook image endpoints and new notebook image types. * Updated REST API (opendatahub-io#155) * Updated with REST API design changes. Fixed formatting error. * Update backend/src/types.ts Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> * Updated type.ts in front end with Succeeded * [byon] Implement backend (opendatahub-io#156) * feat(byon): List all notebooks Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Get single notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * fix(byon): Update api spec to include software and id Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Schedule new notebook import Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Delete notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> * feat(byon): Update notebook Signed-off-by: Tomas Coufal <tcoufal@redhat.com> Co-authored-by: Christopher Chase <cchase@redhat.com> Co-authored-by: Chad Roberts <croberts@redhat.com> Co-authored-by: Juntao Wang <37624318+DaoDaoNoCode@users.noreply.github.com> Co-authored-by: Tom Coufal <7453394+tumido@users.noreply.github.com> fix(byon): Use notebook-image label for visibility toggle (opendatahub-io#169) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> feat(byon): Feat add creator annotation (opendatahub-io#170) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> feat(byon): Allow to patch name and description on notebook (opendatahub-io#172) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> feat(byon): Allow python dependency visibility field changes (opendatahub-io#173) Signed-off-by: Tomas Coufal <tcoufal@redhat.com> Added code for importing byon image. (opendatahub-io#171) Updated front end code with import and start of table. Updated with byon changes Updated code with byon ui changes. Integrated import, delete, and get functionality for notebooks. Added start of edit panel. Updated build error fixes. Updates to edit dialog and linting cleanup. Added sort to table. Added filtering. Added failure warning to allow user to click Add check disable enabling failed notebook images Fixed with review comments. Fixed time bug. Removed admin Update backend port setting and makefile dev commands. (opendatahub-io#133) Use webpack dev server proxy instead of CORS utilities (opendatahub-io#127) Fixed issues with cherry picks. Fixed additional git cherry pick issues. Added ability to add packages, modify packages, etc. Added software package on import. Added additional table and fix some styling issues. Fixed issue where form was submitted. Updated import in notebooksUtils.ts Updated code to work with image streams instead of pipelines. Fixed linting errors. Fixed empty software package bug. Fixed bugs found during testing. Notebook image table update. Fixed error where not showing the empty state. Fixed table issue. Add another update of the notbook image table. Fixed issue where notebook would description disappeared. Fixed missing notification. Prevent duplicate names. Fixed issue with notebook images not updating correctly.

dlabaj requested a review from DaoDaoNoCode April 5, 2022 20:37

dlabaj force-pushed the byon-frontend branch 2 times, most recently from ea2c75c to 69f4feb Compare April 7, 2022 14:18

dlabaj changed the title ~~[WIP] BYON front end code.~~ BYON front end code. Apr 7, 2022

dlabaj force-pushed the byon-frontend branch from 69f4feb to b11818d Compare April 7, 2022 14:35

dlabaj requested a review from LaVLaS April 7, 2022 14:36

tumido reviewed Apr 7, 2022

View reviewed changes

LaVLaS approved these changes Apr 7, 2022

View reviewed changes

DaoDaoNoCode reviewed Apr 7, 2022

View reviewed changes

backend/src/routes/api/notebook/notebooksUtils.ts Show resolved Hide resolved

dlabaj force-pushed the byon-frontend branch from 8ac4250 to 7f00bce Compare April 8, 2022 13:11

dlabaj force-pushed the byon-frontend branch from 7f00bce to 970d97d Compare April 8, 2022 13:12

dlabaj merged commit 5c2cafd into opendatahub-io:BYON Apr 8, 2022

oindrillac mentioned this pull request Apr 13, 2022

Take actions on added images through URL directly from the UI [Admin] open-services-group/byon#16

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BYON front end code. #171

BYON front end code. #171

dlabaj commented Apr 5, 2022 •

edited

dlabaj commented Apr 7, 2022

LaVLaS left a comment

BYON front end code. #171

BYON front end code. #171

Conversation

dlabaj commented Apr 5, 2022 • edited

dlabaj commented Apr 7, 2022

LaVLaS left a comment

Choose a reason for hiding this comment

dlabaj commented Apr 5, 2022 •

edited