-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support k8s websockets #1750
support k8s websockets #1750
Conversation
/hold Target branch is TBD. |
3583677
to
42034c3
Compare
I would say that this should go to something like |
That works for me -- we should also talk about our merging strategy more -- I demoed a loose idea this morning but the process needs work. Things that are not feature roadmap items can't live in |
Yes, we can have a sprint for stability or something and then merge the feature branch, I'm open to any idea here. |
First rundown seems ok, I'm gonna try to get some time today or tomorrow to give a deeper look just in case. |
42034c3
to
dee86d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Tested, running successfully, nothing is broken.
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: DaoDaoNoCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
78398bc
into
opendatahub-io:f/performance
Closes: #1138
Description
Adds support for
dynamic-plugin-sdk
useK8sWatchResource
using web sockets.Note that this PR only adds support for web sockets but does not introduce any usage of web sockets to the application.
Backend:
fastify
to latest versions.@fastify/websocket
./wss/k8s
.safeURLPassThrough
as the related bug has been fixed in thedynamic-plugin-sdk
.Frontend:
dynamic-plugin-sdk
and@openshift/dynamic-plugin-sdk-utils
to latest versions.How Has This Been Tested?
Ad hoc testing with custom test page.
Smoke test current app.
Test Impact
None.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main