-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add access check before deleting model server #1752
Add access check before deleting model server #1752
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Tested. Works fine for me.
cc @kywalker-rh |
Changes lgtm |
cc @vconzola |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Approving this, since it's the outcome of a discussion we had in a previous UX Meeting.
#1320 (comment)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux, manaswinidas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'll throw my LGTM in here too, even though it's already merged. |
Closes #1320
Description
Use
useAccessCheck
hook to check whether the user has access to delete the RoleBinding in the namespace, if not, hide theDelete model server
dropdown item.How Has This Been Tested?
Delete model server
button should be invisibleTest Impact
N/A
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main