Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log group config errors to the pod and refine logic #1866

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Sep 26, 2023

Closes #463

Description

This PR mainly changes the error handle a little bit, to make the error more clear.

  1. When the group is not set, or it's an empty string, show the error No group is set in the group config, please set one or more group. (May need wording)
  2. When the group does not exist, show the error in the pod log (We only showed it in the dashboard notification center before)

How Has This Been Tested?

  1. Change the group config in the dashboard config CR, change the adminGroups to a non-existed group like fake-group
  2. Wait for 2 minutes (We need to wait until the backend fetches the latest cluster data)
  3. Refresh the user management settings page, you should see 2 error messages in both pod logs and dashboard UI
  • The group fake-group no longer exists in OpenShift and has been removed from the selected group list.
  • No group is set in the group config, please set one or more group.
  1. Refresh the page again, you should only see the second message
  2. Try to set or unset the groups, and make sure nothing is broken

Test Impact

Add tests for useWatchGroups hook.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

flow as described is accurate

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested. Works fine.

@christianvogt
Copy link
Contributor

@DaoDaoNoCode please add tests

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, Gkrumbach07, manaswinidas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit b4b169b into opendatahub-io:main Oct 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Dashboard pod logs do not report some expected errors when they happen
4 participants