-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show tooltip on disabled 'Deploy model' button when no project is selected #2283
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM. |
Marking draft briefly while I add some tests |
FWIW @mturley you can always just prefix your PR name with |
Good to know, thanks! |
Added a Cypress test here and marked ready for review again. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Who gets to press the big green button ✅👀 |
@mturley We tend to rebase from main rather than merge to keep the git history clean, and if you can clean up the commit history would be amazing (we are changing our flow now, so maybe we could squash in the future) but for now we try to enforce the least amount of commits per PR! |
…ected Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
@lucferbux got it, sounds good! Just squashed it into one rebased commit and force-pushed. should be good now. |
/lgtm |
Closes https://issues.redhat.com/browse/RHOAIENG-544
Description
Adds a tooltip that appears on the 'Deploy model' button on the global Model Serving page if the button is disabled because no project is selected.
The tooltip is shown here in the empty state when there are no deployed models, but the ServeModelButton component used there is the same one used above the table in the non-empty state of the page, so the tooltip implementation affects both views.
cc @vconzola
How Has This Been Tested?
Viewing the Model Serving page with no project selected, and observing that the disabled button has the new tooltip. Added Cypress test, see below.
Test Impact
Added to existing Cypress tests for the Model Serving page. The new test visits the all-projects view of the page, triggers a mouse hover event on the button and checks that the tooltip is visible.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main