Unit Test Case for useInferenceServices

[uidoyen]

Closes: RHOAIENG-1852

Description

Unit test case for: frontend/src/pages/modelServing/useInferenceServices.ts

How Has This Been Tested?

npm run test

Test Impact

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[christianvogt]

Reject with an instance of Error and assert that error is returned.

Suggested change

	k8sListResourceMock.mockReturnValue(Promise.reject('error'));
	const renderResult = testHook(useInferenceServices)('namespace');
	expect(k8sListResourceMock).toHaveBeenCalledTimes(1);
	expect(renderResult).hookToStrictEqual(standardUseFetchState([], false));
	expect(renderResult).hookToHaveUpdateCount(1);
	// // Wait for the hook to handle the error
	await renderResult.waitForNextUpdate();
	expect(renderResult).hookToStrictEqual(
	standardUseFetchState([], false, new Error('No Inference Services found.')),
	k8sListResourceMock.mockReturnValue(Promise.reject(new Error('error')));
	const renderResult = testHook(useInferenceServices)('namespace');
	expect(k8sListResourceMock).toHaveBeenCalledTimes(1);
	expect(renderResult).hookToStrictEqual(standardUseFetchState([], false));
	expect(renderResult).hookToHaveUpdateCount(1);
	// // Wait for the hook to handle the error
	await renderResult.waitForNextUpdate();
	expect(renderResult).hookToStrictEqual(
	standardUseFetchState([], false, new Error('error')),

[christianvogt]

Remove this change along with the change to the test that mocks the error thrown.

[christianvogt]

@uidoyen please add another test for the missing code coverage. You can assert that k8sListResourceMock has not been called when the NotReadyError use case is encountered.

[uidoyen]

@uidoyen please add another test for the missing code coverage. You can assert that k8sListResourceMock has not been called when the NotReadyError use case is encountered.

@christianvogt Updated the test case based on your comment as well as the latest hook update.

[christianvogt]

@uidoyen you don't have a test case for when namespace is not provided as a param to the hook.

[uidoyen]

@christianvogt added test case when namespace isn't provided. Can you please check it again?

[christianvogt]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment