Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-246] Updated TrustyAIKind apiVersion to trustyai.opendatahub.io #2363

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

alexcreasy
Copy link
Contributor

@alexcreasy alexcreasy commented Jan 19, 2024

[WIP] Testing on a cluster in progress

Closes: RHOAIENG-346

Description

Updates the apiVersion of the TrustyAI CRD to trustyai.opendatahub.io to match a last minute update on the backend.

How Has This Been Tested?

  1. Deploy TrustyAI using these devflags:
    trustyai:
      devFlags:
        manifests:
          - contextDir: config
            sourcePath: ''
            uri: >-
              https://github.com/ruivieira/trustyai-service-operator/tarball/issue-168-apiversion-ui-test
      managementState: Managed
  1. Deploy dashboard image from this PR.
  2. Enable TrustyAI on a project through the dashboard, verify the service is correctly installed.

Test Impact

Small change, existing tests updated, no drop in coverage.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Jan 19, 2024
@andrewballantyne andrewballantyne changed the title [WIP] [RHOAIENG-246] Updated TrustyAIKind apiVersion to trustyai.opendatahub.io [RHOAIENG-246] Updated TrustyAIKind apiVersion to trustyai.opendatahub.io Jan 19, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Jan 19, 2024
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on cluster - looks good. Creates the CR with the shortened api group.

/hold

Waiting on final verification in slack about getting backend in with this frontend change for 2.6.

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Jan 19, 2024
@openshift-ci openshift-ci bot added the lgtm label Jan 19, 2024
Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewballantyne
Copy link
Member

Confirmed

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Jan 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f2de311 into opendatahub-io:main Jan 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants