[WIP] Followup to fix RHOAIENG-556 correctly - Properly dry-run all operations in KServe modal before submitting #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mturley
changed the title
lucferbux
reviewed
Jan 26, 2024
...rc/pages/modelServing/screens/projects/InferenceServiceModal/ManageInferenceServiceModal.tsx
Outdated
Show resolved
Hide resolved
lucferbux
reviewed
Jan 26, 2024
| replicaCount, | ||
| ); | ||
|
|
||
| // TODO mturley add unit test coverage to make sure we don't create any resources if there's an error |
lucferbux
reviewed
Jan 26, 2024
lucferbux
reviewed
Jan 26, 2024
mturley
force-pushed
the
rhoaieng-556-followup
branch
6 times, most recently
from
0773b15
to
cba6416
Compare
… submitting Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
dpanshug
force-pushed
the
rhoaieng-556-followup
branch
from
cba6416
to
ea5c753
Compare
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Closing this PR, creating a new one with changes added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://issues.redhat.com/browse/RHOAIENG-556
@lucferbux realized the changes in #2319 didn't actually fix this issue, we both had the logic backwards when reasoning about it and testing it.
WIP -- needs some further refactoring and new tests.
Description
How Has This Been Tested?
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main