Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added configMap test #2408

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Jan 29, 2024

Closes: https://issues.redhat.com/browse/RHOAIENG-2117

Description

  1. added test case for frontend/src/api/k8s/configMaps.ts
  2. brought down the respective test file within its adjacent tests folder

How Has This Been Tested?

npm run test

Test Impact

test coverage:
Screenshot from 2024-01-29 19-15-22

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@pnaik1 pnaik1 force-pushed the configMap branch 2 times, most recently from bb06c7d to cb29a86 Compare January 30, 2024 16:22
@pnaik1 pnaik1 force-pushed the configMap branch 2 times, most recently from 771944f to 86cefd6 Compare January 31, 2024 09:51
Copy link
Contributor

@dpanshug dpanshug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@christianvogt
Copy link
Contributor

@pnaik1 please fix the name of mockConFigMap.ts => mockConfigMap.ts

@pnaik1
Copy link
Contributor Author

pnaik1 commented Feb 1, 2024

/retest

@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, dpanshug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1203483 into opendatahub-io:main Feb 1, 2024
6 checks passed
@pnaik1 pnaik1 deleted the configMap branch April 24, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants