Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly dry-run all operations in KServe modal before submitting #2470

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

dpanshug
Copy link
Contributor

@dpanshug dpanshug commented Feb 7, 2024

Closes: RHOAIENG-556

Description

In progress to #2319, this PR improves the functionality to dry run ServingRuntime and InferenceService before creating the KServe model.

How Has This Been Tested?

Create a KServe modal and check the network logs to find dryRun API executed first.

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from pnaik1 and uidoyen February 7, 2024 08:28
@dpanshug dpanshug force-pushed the 556-kserve branch 3 times, most recently from 0f48af2 to 1b2987c Compare February 7, 2024 09:50
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, I'm missing some tests coverage in kserve, create a testsuite to cover the case of either serving runtimes or inference services failing in the dry run

@dpanshug dpanshug force-pushed the 556-kserve branch 2 times, most recently from c297d63 to fa57339 Compare February 9, 2024 17:53
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Feb 9, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Feb 9, 2024
@dpanshug
Copy link
Contributor Author

dpanshug commented Feb 9, 2024

/retest

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Feb 9, 2024
@lucferbux
Copy link
Contributor

there's a conflict with a recently merged file, we can check it on monday!

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Great job here!

@openshift-ci openshift-ci bot added the lgtm label Feb 12, 2024
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4788654 into opendatahub-io:main Feb 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants