Unit Test Case for useDraggableTable

[uidoyen]

Closes: RHOAIENG-2120

Description

added unit test for frontend/src/utilities/useDraggableTable.ts

How Has This Been Tested?

npm run test

Test Impact

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[uidoyen]

I was able to get 87.87% of branch coverage.

[christianvogt]

There doesn't seem to be any stability checks being made for the hook return value.
It seems to me like useDraggableTable doesn't care to be stable. That's a problem. Functions like onDragEnd that have no dependencies should be wrapped in useCallback to be made stable. When writing tests, it's important to also evaluate the code being tested for improvements. Please add stability checks when testing hooks.

[uidoyen]

@christianvogt updated the test case accordingly. It's up for review. Thanks!

[christianvogt]

You're testing drag functions individually however when used in pratice, they are called sequence. The only way to establish an internal state is to call the functions in the correct order. For example, onDragEnd will set isDragging to false. Unless you've started your test with a call to onDragStart, there's no way you can assert the class name has changed because of a change to isDragging.

I suggest you add at least one end to end test case that runs through the happy path.

[uidoyen]

@christianvogt. Thank you for the feedback and suggestion, Based on your comment, I have used a different approach and made the necessary updates.

[uidoyen]

/retest

[christianvogt]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment