Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cypress tests to assert delete in ServingRuntimeList #2597

Conversation

ashley-o0o
Copy link
Contributor

@ashley-o0o ashley-o0o commented Mar 13, 2024

Closes: RHOAIENG-3838

Description

This PR aims to update existing cypress tests on ServingRuntimeList.cy.ts to test the delete functionality for model servers

How Has This Been Tested?

npm run test

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from pnaik1 and ppadti March 13, 2024 15:05
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Mar 13, 2024
@ashley-o0o ashley-o0o force-pushed the cypress/servingRuntimeDelete branch 2 times, most recently from 80c5b6a to d97f0d0 Compare March 13, 2024 19:26
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Mar 13, 2024
@pnaik1
Copy link
Contributor

pnaik1 commented Mar 14, 2024

@ashley-o0o Can you please review the checklist in the PR's description?

@pnaik1
Copy link
Contributor

pnaik1 commented Mar 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 19, 2024
@openshift-ci openshift-ci bot removed the lgtm label Mar 20, 2024
@ashley-o0o ashley-o0o force-pushed the cypress/servingRuntimeDelete branch 2 times, most recently from b2ffe22 to 7f26443 Compare March 20, 2024 17:30
@christianvogt
Copy link
Contributor

/retest

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Mar 20, 2024
Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bff8eb9 into opendatahub-io:main Mar 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants