-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cypress tests to assert delete in ServingRuntimeList #2597
Update Cypress tests to assert delete in ServingRuntimeList #2597
Conversation
80c5b6a
to
d97f0d0
Compare
4930d73
to
272b662
Compare
frontend/src/__tests__/cypress/cypress/e2e/modelServing/ServingRuntimeList.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/e2e/modelServing/ServingRuntimeList.cy.ts
Outdated
Show resolved
Hide resolved
@ashley-o0o Can you please review the checklist in the PR's description? |
272b662
to
273431b
Compare
273431b
to
8267852
Compare
frontend/src/__tests__/cypress/cypress/e2e/modelServing/ServingRuntimeList.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/e2e/modelServing/ServingRuntimeList.cy.ts
Outdated
Show resolved
Hide resolved
8267852
to
a928157
Compare
a928157
to
360ddc5
Compare
/lgtm |
frontend/src/__tests__/cypress/cypress/e2e/modelServing/ServingRuntimeList.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/e2e/modelServing/ServingRuntimeList.cy.ts
Outdated
Show resolved
Hide resolved
360ddc5
to
5254963
Compare
b2ffe22
to
7f26443
Compare
/retest |
7f26443
to
ae1a505
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-3838
Description
This PR aims to update existing cypress tests on ServingRuntimeList.cy.ts to test the delete functionality for model servers
How Has This Been Tested?
npm run test
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main