Add wrap text option for pipeline run logs #2616
Conversation
|
@yih-wang Could you check the screenshot to see if it's accurate? |
|
@DaoDaoNoCode Can you give me a screenshot of how it looks like in the minSize of the drawer? I think it's fine to have the 'wrap text' and 'download' both outside the kebab. But I want to confirm that it doesn't cause any wrapping issues when the drawer is minSize. |
|
@yih-wang Sure, this is the min size, I cannot shrink it anymore. 
|
|
@DaoDaoNoCode Any mess if you start searching and input a single character in the search box? |
|
@yih-wang Ah yes, it gets a little bit weird. |
|
so that's what I meant. We need to extend the minSize of the drawer, or hide one of the 'wrap text' and 'download' into the kebab to make it neat. |
|
That said, this kind of wrap seems acceptable to me... I'm not sure how many users would see this wrapping layout. If only 10% of them, I think we can keep it as is since keep both the wrap text and download in the toolbar would bring most convinience. |
|
@yih-wang I can extend the min size a little bit. The following screenshot extends it for about 50px, do you think this is acceptable? If so I will go with this solution. |
|
can you try to type a character in the search box? Because it will add the length of the search box. |
|
@yih-wang I see, it breaks the layout again, so I added 20px more to it, then it's OK now as the screenshot shows. 
|
|
I would say add at least 50px more... Since we will also have a status icon when the log is still running. And if the number (1/256) in the search box is longer, it would even take more space. |
|
And I'm not sure if it's too large for a minSize after adding another 50px... If so, let's go back to what you originally have (with wrapped 'wrap text') since it looks not so bad. |
|
@yih-wang How does this look like? It's 100px more compared to the very original one. If not enough I can make it to 120px more. 
|
|
Yeah, maybe I won't change anything about the min size if you think it's not a big deal. |
|
Sounds good to me. Let's stick to your original version. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: Gkrumbach07, jpuzz0, manaswinidas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JIRA: RHOAIENG-3830
Description
There is some problem with the PF log viewer, which is causing the incorrect rendering for the extremely long log lines. In the OpenShift console, the solution is to truncate the line. However, it's limited currently in the dashboard for now because we haven't applied websocket on the logs, so it's hard to truncate a single line of the logs (it's a full string now). After a discussion with the UX, we decided to add an option to allow the users to check whether they want to wrap the text in the log viewer or not. In this way, they can view the incorrectly rendered logs by unchecking the
Wrap textcheckbox in the toolbar.Also, update the text in the alert because we don't truncate the exceptionally long lines :)
How Has This Been Tested?
Test Impact
N/A, it's a simple update with the built-in log viewer interface.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main