Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Accelerator profile cypress test #2622

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented Mar 21, 2024

Closes: https://issues.redhat.com/browse/RHOAIENG-3818

Description

This PR aims to update the accelerator profile cypress test. Also added a generic component for filter and search functionality, and applied it to the NotebookImageSetting file and ServingRuntimeList file.

How Has This Been Tested?

npm run test

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Mar 22, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Mar 28, 2024
Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 1, 2024
@pnaik1
Copy link
Contributor

pnaik1 commented Apr 2, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 2, 2024
@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 71a0e59 into opendatahub-io:main Apr 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants