Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-5067: Model Serving Metrics: Use real namespace name instead of project display name in queries #2657

Conversation

mturley
Copy link
Contributor

@mturley mturley commented Apr 2, 2024

Closes https://issues.redhat.com/browse/RHOAIENG-5067 (Critical)

Description

As identified by @christianvogt, the ProjectServerMetricsWrapper was passing the current project's display name into ModelServingMetricsProvider instead of the namespace name. This was making its way into the Prometheus query strings in the Model Serving Metrics page, causing 400 Bad Request errors.

How Has This Been Tested?

Created a model server in a project whose display name is different from its underlying namespace (e.g. it has capital letters or spaces in it). Tried to view the model server metrics (Projects -> [project] -> Models tab -> Kebab menu -> View model server metrics) and saw that before this change I got 400 errors in the dev tools Network tab and the loading spinners on the page never resolved. After this change the queries resolve correctly.

I also sent some requests to a deployed model with curl and observed that the metrics appear correctly on the page.

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

… of project display name in queries

Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 42c0f11 into opendatahub-io:main Apr 2, 2024
6 checks passed
@mturley mturley deleted the 5067-model-server-metrics-400 branch April 2, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants