Support listing all available namespaces #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cfchase please review 🙂 |
tumido
force-pushed
the
support-multiple-namespaces
branch
from
fba8e9c
to
bb9193f
Compare
This was referenced Dec 2, 2020
jeff-phillips-18
added a commit
to jeff-phillips-18/odh-dashboard
that referenced
this pull request
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26
Back-end implementation. If it's intended to visualize this in any way on front-end, there should come another PR for that.
This PR makes the node back-end to lookup for all namespaces to which it has access to (via Openshift
projectresource). This happens at the server startup. If this lookup fails, it falls back to using the original implementation for looking up the current namespace.During runtime, when serving requests to
/api/components, the component lookup code tries for fetch all kfdef resources in all available namespaces (even when multiplekfdefsare present in the same namespace) and then builds the application list out of it.Later on, it may be needed to change the lookup logic to allow for duplicate apps listing.
The available namespaces are determined by Openshift RBAC - only the namespaces to which the ODH dashboard's service account has access to, are queried.
Backend now lists the namespace property for each enabled component in the
/api/componentsresponse.