Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ProjectList Cypress test #2733

Merged

Conversation

ashley-o0o
Copy link
Contributor

@ashley-o0o ashley-o0o commented Apr 19, 2024

Closes: RHOAIENG-3836

Description

This PR validates when workbench is in running state, that clicking on switch toggle will open modal to stop workbench. The Name and User table filtering, searching, and sorting functionality works properly, and that an Invalid Project name will open error page.

How Has This Been Tested?

npm run test

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@ashley-o0o ashley-o0o force-pushed the cypress/ProjectList3836 branch 2 times, most recently from f1d71c9 to f86985a Compare April 19, 2024 20:54
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Apr 23, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Apr 23, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Apr 23, 2024
@ashley-o0o ashley-o0o force-pushed the cypress/ProjectList3836 branch 2 times, most recently from 25f79ee to d6730ea Compare April 23, 2024 14:07
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Apr 23, 2024
@ashley-o0o ashley-o0o force-pushed the cypress/ProjectList3836 branch 5 times, most recently from 596da2b to 9eda0bb Compare April 25, 2024 16:23
@ppadti
Copy link
Contributor

ppadti commented Apr 25, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 25, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label May 1, 2024
@openshift-ci openshift-ci bot removed the lgtm label May 2, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label May 2, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label May 2, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label May 2, 2024
@ppadti
Copy link
Contributor

ppadti commented May 2, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 2, 2024
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented May 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e7bb999 into opendatahub-io:main May 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants