Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the resource handling and move the logic to InferenceServices #2737

Merged
merged 1 commit into from
May 6, 2024

Conversation

lucferbux
Copy link
Contributor

Closes https://issues.redhat.com/browse/RHOAIENG-340

Description

No UX changes

Refactor on resource handling in KServe from ServingRuntime spec to InferenceService spec, including migration path.

How Has This Been Tested?

Migration path

  1. Deploy a KServe model with the code in main
  2. Check that InferenceService is deployed with inferenceService?.spec.predictor.model.resources as an empty object
  3. Check that ServingRuntime is deployed with servingRuntime.spec.containers[0]?.resources with the current size
  4. Check that the pod is deployed and everything is working right
  5. Switch the code to this branch
  6. Check that you can see the correct size
  7. Edit the deployed model
  8. Check that the model server size is correctly displayed
  9. Update the model
  10. Check that InferenceService is deployed with inferenceService?.spec.predictor.model.resources filled with the data.
  11. Check that ServingRuntime is deployed with servingRuntime.spec.containers[0]?.resources removed.

New deployment

  1. In the current branch
  2. Deploy a new kserve model
  3. Check that InferenceService is deployed with inferenceService?.spec.predictor.model.resources filled with the data.
  4. Check that ServingRuntime is deployed with servingRuntime.spec.containers[0]?.resources removed.
  5. Check that the size is displayed on the model info

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@lucferbux lucferbux requested review from mturley and alexcreasy and removed request for DaoDaoNoCode April 22, 2024 13:20
@lucferbux lucferbux changed the title Change the resource handling to InferenceServices Change the resource handling and move the logic to InferenceServices Apr 22, 2024
@lucferbux lucferbux force-pushed the rhoaieng-340 branch 3 times, most recently from 00ed207 to fe5aaa8 Compare April 23, 2024 08:46
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Apr 24, 2024
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the caveat that I still have limited familiarity with model serving, LGTM

@lucferbux
Copy link
Contributor Author

/approve

Copy link
Contributor

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit bbe19c1 into opendatahub-io:main May 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants