Change the resource handling and move the logic to InferenceServices #2737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://issues.redhat.com/browse/RHOAIENG-340
Description
No UX changes
Refactor on resource handling in KServe from
ServingRuntime
spec toInferenceService
spec, including migration path.How Has This Been Tested?
Migration path
main
InferenceService
is deployed withinferenceService?.spec.predictor.model.resources
as an empty objectServingRuntime
is deployed withservingRuntime.spec.containers[0]?.resources
with the current sizeInferenceService
is deployed withinferenceService?.spec.predictor.model.resources
filled with the data.ServingRuntime
is deployed withservingRuntime.spec.containers[0]?.resources
removed.New deployment
InferenceService
is deployed withinferenceService?.spec.predictor.model.resources
filled with the data.ServingRuntime
is deployed withservingRuntime.spec.containers[0]?.resources
removed.Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main