Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-6985] Create kserve metrics feature flag #2795

Conversation

jeff-phillips-18
Copy link
Contributor

@jeff-phillips-18 jeff-phillips-18 commented May 9, 2024

Closes: RHOAIENG-6985

Description

Initial creation fo the kserve metric feature, disabled by default. Includes a simple Coming soon page.

How Has This Been Tested?

Tested locally and added e2e tests

Test Impact

Verify that the user can navigate to the kserve metrics page from the model list view by clicking on the model name ONLY if the feature flag is enabled.

Screen shots

image

image

image

Request review criteria:

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • Included any necessary screenshots or gifs if it was a UI change.

@openshift-ci openshift-ci bot requested a review from ppadti May 9, 2024 15:40
@jeff-phillips-18 jeff-phillips-18 force-pushed the kserve-metrics-feature branch 2 times, most recently from 320c84f to 4f96037 Compare May 10, 2024 11:55
Copy link
Contributor

@alexcreasy alexcreasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, however I found an issue in testing.

When ModelMesh is disabled in the DSC but Kserve is enabled there are two issues:

  1. There is no link to the metrics page from the data science project details route
  2. Whilst there is a link from the Global model serving route, the link is broken and ends up with an infinity spinner.

This could have something to do with how the model metrics area is defined - right now it depends on modelmesh being installed, which might contribute to this issue?

frontend/src/concepts/areas/const.ts Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.45%. Comparing base (8645fe6) to head (b5648a4).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2795      +/-   ##
==========================================
+ Coverage   77.32%   77.45%   +0.12%     
==========================================
  Files        1093     1093              
  Lines       23026    23043      +17     
  Branches     5799     5808       +9     
==========================================
+ Hits        17805    17848      +43     
+ Misses       5221     5195      -26     
Files Coverage Δ
frontend/src/concepts/areas/const.ts 100.00% <ø> (ø)
frontend/src/concepts/areas/types.ts 100.00% <100.00%> (ø)
frontend/src/k8sTypes.ts 100.00% <ø> (ø)
...erving/screens/global/InferenceServiceTableRow.tsx 96.77% <100.00%> (+0.77%) ⬆️
...Serving/screens/metrics/GlobalModelMetricsPage.tsx 100.00% <ø> (ø)
...s/modelServing/screens/metrics/MetricsPageTabs.tsx 75.00% <100.00%> (+5.76%) ⬆️
...ing/screens/metrics/performance/PerformanceTab.tsx 100.00% <100.00%> (+50.00%) ⬆️
...rving/screens/projects/ProjectModelMetricsPage.tsx 100.00% <ø> (+80.00%) ⬆️
.../serverModels/deployedModels/DeployedModelCard.tsx 92.30% <100.00%> (+0.64%) ⬆️
...pages/modelServing/screens/metrics/MetricsPage.tsx 86.66% <80.00%> (-5.00%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8645fe6...b5648a4. Read the comment docs.

@alexcreasy
Copy link
Contributor

@jeff-phillips-18 there's just one more thing I've noticed:
For kserve there's no link on the Project -> Overview tab widget for kserve, but it works for modelmesh.

Screenshot 2024-05-15 at 16 59 19

Otherwise all good!

@openshift-ci openshift-ci bot added the lgtm label May 15, 2024
Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcreasy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label May 15, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label May 15, 2024
@alexcreasy
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f945d43 into opendatahub-io:main May 16, 2024
8 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the kserve-metrics-feature branch May 16, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants