-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress test for pipeline pagination #2800
Cypress test for pipeline pagination #2800
Conversation
For Archived run, table is not properly getting updated with mock data. So I was not able to add pagination tests for that table. |
e406da6
to
46cb56e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also opportunity to avoid duplication of tests here and create utilities that can test the pagination functionality of the various tables on different pages since they all function the same way.
frontend/src/__tests__/cypress/cypress/e2e/pipelines/PipelineRuns.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/e2e/pipelines/PipelineRuns.cy.ts
Outdated
Show resolved
Hide resolved
46cb56e
to
40d2c5c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2800 +/- ##
=======================================
Coverage ? 78.17%
=======================================
Files ? 1076
Lines ? 22615
Branches ? 5718
=======================================
Hits ? 17679
Misses ? 4936
Partials ? 0 Continue to review full report in Codecov by Sentry.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
95611b7
into
opendatahub-io:main
Closes: RHOAIENG-5117
Description
follow up to #2745
This PR to add pagination to pipeline and pipeline run tables.
How Has This Been Tested?
npm run test
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main