Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress test for pipeline pagination #2800

Merged
merged 1 commit into from
May 14, 2024

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented May 10, 2024

Closes: RHOAIENG-5117

Description

follow up to #2745
This PR to add pagination to pipeline and pipeline run tables.

How Has This Been Tested?

npm run test

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from pnaik1 and uidoyen May 10, 2024 10:27
@ppadti
Copy link
Contributor Author

ppadti commented May 10, 2024

For Archived run, table is not properly getting updated with mock data. So I was not able to add pagination tests for that table.

@ppadti ppadti force-pushed the pipeline-pagination branch 2 times, most recently from e406da6 to 46cb56e Compare May 10, 2024 11:34
@ppadti ppadti requested a review from christianvogt May 13, 2024 06:52
Copy link
Contributor

@christianvogt christianvogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also opportunity to avoid duplication of tests here and create utilities that can test the pagination functionality of the various tables on different pages since they all function the same way.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@fa06535). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2800   +/-   ##
=======================================
  Coverage        ?   78.17%           
=======================================
  Files           ?     1076           
  Lines           ?    22615           
  Branches        ?     5718           
=======================================
  Hits            ?    17679           
  Misses          ?     4936           
  Partials        ?        0           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa06535...40d2c5c. Read the comment docs.

@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 95611b7 into opendatahub-io:main May 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants