Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Grafana component names #33

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

tumido
Copy link
Contributor

@tumido tumido commented Dec 3, 2020

@cfchase cfchase merged commit 4ebc0b9 into opendatahub-io:master Dec 8, 2020
@cfchase
Copy link
Member

cfchase commented Dec 14, 2020

@tumido did you test this out? Unfortunately I merged this, but I'm still seeing a grafana-instance component in my installation. @LaVLaS maybe you can clarify this?

https://github.com/opendatahub-io/odh-manifests/blob/master/tests/setup/kfctl_openshift.yaml#L48

cfchase added a commit that referenced this pull request Dec 14, 2020
cfchase pushed a commit that referenced this pull request Dec 14, 2020
cfchase added a commit that referenced this pull request Dec 14, 2020
@tumido
Copy link
Contributor Author

tumido commented Dec 16, 2020

Hm.. I'm pretty sure I saw grafana-operator in there before, but sure it doesn't say it as well as nowhere in the history of that file... Which is weird.

Anyways. On the other hand the documentation is consistent with this PR here. Which is confusing even more. You're right @cfchase, we probably need some more clarity on this and a naming convention would help... I've filed an issue here with comparison table listing further inconsistencies: https://github.com/opendatahub-io/odh-manifests/issues/270

@tumido tumido deleted the fix-grafana branch January 21, 2021 15:37
jeff-phillips-18 pushed a commit to jeff-phillips-18/odh-dashboard that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants