Front end coded, backend api updated for tolerations. #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlabaj
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
lucferbux
reviewed
Aug 23, 2022
backend/src/routes/api/cluster-settings/clusterSettingsUtils.ts
Outdated
Show resolved
Hide resolved
|
@dlabaj Can you rebase this PR? |
dlabaj
force-pushed
the
kfnbc-tol-333
branch
2 times, most recently
from
6621d16
to
c4d1a38
Compare
DaoDaoNoCode
requested changes
Aug 23, 2022
backend/src/routes/api/cluster-settings/clusterSettingsUtils.ts
Outdated
Show resolved
Hide resolved
DaoDaoNoCode
requested changes
Aug 23, 2022
dlabaj
force-pushed
the
kfnbc-tol-333
branch
3 times, most recently
from
dc3d8d7
to
f461097
Compare
Fixed linting error. Updates to backend and frontend code. Updated to set toleration for notebook. Fixed notebookTolerationSettings. Fixed linting error fixed issue with default settings. Removed dead code Removed unused import Removed any from body constant Added toleration support for notebooks. Added toleration support in cluster settings, and updated code to add toleration to notebooks if it's enabled. Added toleration support in cluster settings, and updated code to add toleration to notebooks if it's enabled.
DaoDaoNoCode
approved these changes
Aug 23, 2022
DaoDaoNoCode
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@DaoDaoNoCode checked, everything seems great now! |
LaVLaS
pushed a commit
to LaVLaS/odh-dashboard
that referenced
this pull request
Aug 26, 2022
Fixed linting error. Updates to backend and frontend code. Updated to set toleration for notebook. Fixed notebookTolerationSettings. Fixed linting error fixed issue with default settings. Removed dead code Removed unused import Removed any from body constant Added toleration support for notebooks. Added toleration support in cluster settings, and updated code to add toleration to notebooks if it's enabled. Added toleration support in cluster settings, and updated code to add toleration to notebooks if it's enabled.
LaVLaS
pushed a commit
to red-hat-data-services/odh-dashboard
that referenced
this pull request
Aug 31, 2022
Fixed linting error. Updates to backend and frontend code. Updated to set toleration for notebook. Fixed notebookTolerationSettings. Fixed linting error fixed issue with default settings. Removed dead code Removed unused import Removed any from body constant Added toleration support for notebooks. Added toleration support in cluster settings, and updated code to add toleration to notebooks if it's enabled. Added toleration support in cluster settings, and updated code to add toleration to notebooks if it's enabled.
strangiato
pushed a commit
to strangiato/odh-dashboard
that referenced
this pull request
Oct 18, 2023
Fixed linting error. Updates to backend and frontend code. Updated to set toleration for notebook. Fixed notebookTolerationSettings. Fixed linting error fixed issue with default settings. Removed dead code Removed unused import Removed any from body constant Added toleration support for notebooks. Added toleration support in cluster settings, and updated code to add toleration to notebooks if it's enabled. Added toleration support in cluster settings, and updated code to add toleration to notebooks if it's enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to #338 Updates the cluster settings with notebook toleration per designs and jira issue https://issues.redhat.com/browse/RHODS-3624
Description
Adds the ability to set notebook toleration via the cluster settings
How Has This Been Tested?
Merge criteria:
Testing instructions: