Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group check for cluster-admin #465

Merged

Conversation

lucferbux
Copy link
Contributor

Description

Fixes #464

How Has This Been Tested?

  1. Create a new group
  2. Add a cluster-admin rolebinding
  3. Add a user to that group
  4. The user should have cluster-admin roles
  5. Log in to the dashboard
  6. The user should have cluster-admin permission in the dashboard

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ran the following tests:

  • Added a new user with no permissions
  • Did a before your PR test on main
    • Group of me, was not granted admin access
    • User of me, was granted admin access
  • Did a on your PR test
    • Group of me, was granted access
    • User of me, was granted access
    • Group of not me, was not granted access

All along I could, being part of the group or directly the user, have no permissions issues fetching items locally (until I was no longer a cluster admin -- in the last bullet).

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7cf8b90 into opendatahub-io:main Aug 31, 2022
DaoDaoNoCode pushed a commit to DaoDaoNoCode/odh-dashboard that referenced this pull request Aug 31, 2022
strangiato pushed a commit to strangiato/odh-dashboard that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cluster Admin check doesn't get group rolebinding
3 participants