Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging for admin groups manipulation within dashboard config instance #577

Closed

Conversation

mlassak
Copy link
Contributor

@mlassak mlassak commented Sep 20, 2022

Resolves: #463

Description

Adds logging for the mentioned cases of changing the odh-dashboard-config CRD instance.

How Has This Been Tested?

Tested locally through modifying the odh-dashboard-config CRD instance on the cluster and checking responses from config GET calls on the backend.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andrewballantyne for approval by writing /assign @andrewballantyne in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should let @lucferbux lead this one... not sure what he was thinking.

/assign @lucferbux

export const getDashboardConfig = (): DashboardConfig => {
const config = dashboardConfigWatcher.getResources()?.[0];
validateDashboardConfig(config);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucferbux this will log a lot -- any ideas a better way to approach this? Maybe we do this as part of startup?

We can't do it on set... so did you have another thought?

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Nov 19, 2022
@openshift-merge-robot
Copy link
Contributor

@mlassak: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lucferbux
Copy link
Contributor

Closing this PR, we might wanna explore other alternatives.

@lucferbux lucferbux closed this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase PR needs to be rebased
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Dashboard pod logs do not report some expected errors when they happen
4 participants