New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logging of 404 error responses for pvc, configmaps and secrets #618

Merged

openshift-merge-robot merged 1 commit into opendatahub-io:main from mlassak:spawner-page-404-reporting

Oct 5, 2022

Contributor

mlassak commented Oct 4, 2022 •

edited by andrewballantyne

Resolves: #595

Description

Removed logging of 404 error responses for (yet) non-existing pvcs, configmaps and secrets

How Has This Been Tested?

delete the resources in question, simulating a new user startup
open notebook controller spawner
verify dashboard logs do not contain error records after completed GET requests on api/pvc, api/configmaps and api/secrets

Merge criteria:

The commits are squashed in a cohesive manner and have meaningful messages.
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work


          modified logging of 404s for pvc, configmaps and secrets

0c7146f

openshift-ci bot requested review from DaoDaoNoCode and LaVLaS

October 4, 2022 14:21

andrewballantyne approved these changes

View reviewed changes

openshift-ci bot assigned andrewballantyne

openshift-ci bot added the lgtm label

Contributor

openshift-ci bot commented Oct 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the approved label

openshift-merge-robot merged commit 5e9f2bc into opendatahub-io:main

strangiato pushed a commit to strangiato/odh-dashboard that referenced this pull request


          modified logging of 404s for pvc, configmaps and secrets (opendatahub…

74d3b5d

…-io#618)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment