Allow use of ConsoleLinks for route determination. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, allow <CLUSTER_ID/> as a replaceable variable in endpoint routes and for getting started links.
cdcabrera
approved these changes
Jul 22, 2021
cfchase
approved these changes
Jul 22, 2021
Yeah. I'll add them. |
jeff-phillips-18
added a commit
to jeff-phillips-18/odh-dashboard
that referenced
this pull request
Jul 23, 2021
Also, allow <CLUSTER_ID/> as a replaceable variable in endpoint routes and for getting started links.
jeff-phillips-18
added a commit
to jeff-phillips-18/odh-dashboard
that referenced
this pull request
Jul 27, 2021
opendatahub-io#115) Also, allow <CLUSTER_ID/> as a replaceable variable in endpoint routes and for getting started links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Jira: https://issues.redhat.com/browse/RHODS-750
Jira: https://issues.redhat.com/browse/RHODS-245
Analysis / Root cause:
To determine the route for some applications, we need to find the ConsoleLink associated with the application.
Other applications may need to specify an endpoint (full URL) for the route.
Solution Description:
Allow the application to specify a ConsoleLink to use to find the URL from (the spec.href field).
Allow the application to specify an endpoint for the route.
Also, allow <CLUSTER_ID/> as a replaceable variable in endpoint routes and for getting started links.