Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status popover when storage is nearly full #842

Merged
merged 3 commits into from Dec 8, 2022
Merged

Add status popover when storage is nearly full #842

merged 3 commits into from Dec 8, 2022

Conversation

DaoDaoNoCode
Copy link
Member

Description

Closes #748

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot added the lgtm label Dec 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 8, 2022
@openshift-merge-robot openshift-merge-robot merged commit 0fbbb3d into opendatahub-io:main Dec 8, 2022
strangiato pushed a commit to strangiato/odh-dashboard that referenced this pull request Oct 18, 2023
@DaoDaoNoCode @strangiato
Add status popover when storage is nearly full (opendatahub-io#842)
0fa3db1 
* Add status popover when storage is nearly full

* address comments

* small update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@lucferbux lucferbux Awaiting requested review from lucferbux

@maroroman maroroman Awaiting requested review from maroroman

Assignees

@andrewballantyne andrewballantyne

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DSG] When PVC gets close, warning icon should appear on Cluster Storage row
3 participants
@DaoDaoNoCode @andrewballantyne @openshift-merge-robot