Modify logout and control panel redirect for project notebooks #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewballantyne
requested changes
Dec 8, 2022
DaoDaoNoCode
force-pushed
the
upstream-issue-808
branch
from
1105f45
to
49d3cbb
Compare
frontend/src/pages/projects/screens/detail/useCheckLogoutParams.ts
Outdated
Show resolved
Hide resolved
frontend/src/pages/projects/screens/detail/useCheckLogoutParams.ts
Outdated
Show resolved
Hide resolved
DaoDaoNoCode
force-pushed
the
upstream-issue-808
branch
from
7bf29cb
to
e85fee1
Compare
andrewballantyne
requested changes
Dec 9, 2022
frontend/src/pages/projects/screens/detail/useCheckLogoutParams.ts
Outdated
Show resolved
Hide resolved
andrewballantyne
approved these changes
Dec 9, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
strangiato
pushed a commit
to strangiato/odh-dashboard
that referenced
this pull request
Oct 18, 2023
…atahub-io#846) * Modify logout and control panel redirect for project notebooks * address comments * use hook provided by react-router-dom instead of custom hook * remove comment * add notebook name in the success prompt * modify hook * handle no notebook situation * reduce hook running time * get the correct notebook name * update prompt text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #808
There is no way to change the text Hub Control Panel, it's hardcoded in JupyterLab https://github.com/jupyterlab/jupyterlab/blob/master/packages/hub-extension/src/index.ts#L74-L80
The logout success prompt will be triggered twice, have no idea why, left a comment and waiting for reviews.
How Has This Been Tested?
Create a notebook in DSG, login to the notebook, and try to click the logout and hub control panel button.
Merge criteria: