-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent RedHat supported icon on application card title from being alone on a line #947
Prevent RedHat supported icon on application card title from being alone on a line #947
Conversation
Co-authored-by: Andrew Ballantyne <8126518+andrewballantyne@users.noreply.github.com>
…ashboard into explore-card-text-wrap
fixed issue in a new commit
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FWIW -- I am not a huge fan of the padding override -- I have followed up with PF here: https://patternfly.slack.com/archives/C4FM977N0/p1676392165096129 |
…one on a line (opendatahub-io#947) * prevent supported icon from being alone on a line * Update frontend/src/components/SupportedAppTitle.tsx Co-authored-by: Andrew Ballantyne <8126518+andrewballantyne@users.noreply.github.com> * removed function, added aria labels * removed aria labels, made icon accessible --------- Co-authored-by: Andrew Ballantyne <8126518+andrewballantyne@users.noreply.github.com>
Description
Fix: #879
Split application card title string so that the last word is always on the same line as the RedHat supported icon.
How Has This Been Tested?
Merge criteria: