This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Fix rhods-9627 #866
Merged
Fix rhods-9627 #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jooho <jlee@redhat.com>
This was referenced Jul 5, 2023
israel-hdez
approved these changes
Jul 5, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
VaishnaviHire
added a commit
that referenced
this pull request
Jul 14, 2023
* Fix rhods-9627 (#866) fix rhods-9627 Signed-off-by: jooho <jlee@redhat.com> * Dashboard v2.12.0 release (#854) * Add KServe manifests to odh-manifests Update folder structure and KServe fork url Pre-build KServe manifests to avoid issues with kfctl Change the webhook certificates Add runtime field to example InferenceService fix minor issues fix labels no cert-manager no certmanager Use images from quay.io/opendatahub version 0.10.2 Fetch manifests from opendatahub-io/kserve Revert back to assembled manifests KServe manifests using `kustomize` directly Remove istio-cni env variable in controller Simplify folder structure Use release-0.10 branch to generate built yaml Fix configuration params * Remove KfDef ref from ODHApplications (#872) * Add defaults to env variables --------- Signed-off-by: jooho <jlee@redhat.com> Co-authored-by: Jooho Lee <jlee@redhat.com> Co-authored-by: Andrew Ballantyne <8126518+andrewballantyne@users.noreply.github.com> Co-authored-by: Reto Lehmann <retocode@icloud.com>
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the new manifests, it tries to use a new label to explain components but it causes an upgrade fail because the spec.selector in the deployment is immutable.
In order to upgrade properly, I rollback the labels.
How Has This Been Tested?
It does not impact a fresh cluster installation. I tested this with RHODS live builder image
Live Builder image: quay.io/jooholee/rhods-operator-live-catalog:1.29.0-rhods-9627
You can test the image with the cluster that installed 1.28 RHODS
Merge criteria: